Closed
Bug 1099857
Opened 10 years ago
Closed 10 years ago
about:support as homepage doesn't work with e10s
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
People
(Reporter: pascalc, Assigned: ttaubert)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.78 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0 1/ Set about:support as homepage 2/ activate e10s 3/ restart browser expected result: Firefox restarts and about:support is opened actual result: Firefox restarts with a blank page opened If you open a new window from that blank page, it will open with about:support. If you deactivate e10s, it works.
Assignee | ||
Updated•10 years ago
|
Blocks: 1075658
Keywords: regression
Assignee | ||
Comment 1•10 years ago
|
||
With about:home as the homepage we're trying to switch the remoteness of the initial tab very early when SessionStore wasn't initialized yet. If LoadInOtherProcess() fails we should just switch remoteness manually and load the page. There won't be any history anyway.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8523451 -
Flags: review?(dtownsend+bugmail)
Comment 2•10 years ago
|
||
Comment on attachment 8523451 [details] [diff] [review] 0001-Bug-1099857-about-support-as-homepage-doesn-t-work-w.patch Review of attachment 8523451 [details] [diff] [review]: ----------------------------------------------------------------- Seems reasonable. We could also detect when loading that the tab only has one thing in the history not marked to be persisted (about:blank) and shortcut in that case. Maybe something for another bug if at all though.
Attachment #8523451 -
Flags: review?(dtownsend+bugmail) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/dd555a81cbba
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dd555a81cbba
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Comment 5•10 years ago
|
||
Hi Tim, can you provide a point value and set it for QE verification.
Iteration: --- → 36.3
Flags: qe-verify?
Flags: needinfo?(ttaubert)
Flags: firefox-backlog+
Assignee | ||
Updated•10 years ago
|
Points: --- → 2
Flags: qe-verify?
Flags: qe-verify+
Flags: needinfo?(ttaubert)
Updated•10 years ago
|
QA Contact: florin.mezei
Comment 6•10 years ago
|
||
Reproduced the original issue with Firefox 36 Nightly from November 17. The original issue no longer reproduced on Win 7 x64, Ubuntu 14.04 x64, Mac OS X 10.9.5, with the latest Firefox 36 Nightly build (BuildID=20141118144012), as about:support was correctly displayed when opening Nightly with e10s enabled (other "about:x" pages also opened correctly). There is one edge case though: 1. Set an incorrect "about:x" as homepage (e.g. "about:suppor"). 2. Make sure e10s is active. 3. Restart browser. Expected results: "The address isn't valid" error page displays, and the incorrect "about:x" displays in the location bar, so the user can identify the mistake. This is the behavior with e10s disabled. Actual results: Firefox restarts with a blank page opened. Tim, should this be reopened for the remaining edge case, or should it be tracked in a separate bug (I'm not sure whether it's the same cause)?
Flags: needinfo?(ttaubert)
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Florin Mezei, QA (:FlorinMezei) from comment #6) > Tim, should this be reopened for the remaining edge case, or should it be > tracked in a separate bug (I'm not sure whether it's the same cause)? I think we should open a new bug for that. Can't unfortunately tell whether that is related without further investigation.
Flags: needinfo?(ttaubert)
You need to log in
before you can comment on or make changes to this bug.
Description
•