Closed Bug 1100114 Opened 10 years ago Closed 9 years ago

Implement the new style for about:newaddon

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(2 files, 2 obsolete files)

Screenshot for easier ui-r
23.12 KB, image/png
Details
new-newaddon-page.patch
12.37 KB, patch
mossop
: review+
Details | Diff | Splinter Review 
Implement the new style for about:newaddon through using in-content/common.css instead of inContentUI.css.
Attached patch new-newaddon-page.patch (obsolete) — — Splinter Review 
This patch uses in-content/common.css instead of inContentUI.css.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8523524 - Flags: ui-review?(mmaslaney)

    
  
Blocks: 1097111

    
    

    
  

      
      
      
      

        Attached patch
          
          
        new-newaddon-page.patch (obsolete)
        — 
          — Splinter Review
      

    


  
Updated to tip after override patch.

Philipp, I also added you to look if it needs changes.

        Attachment #8523524 -
        Attachment is obsolete: true

        Attachment #8523524 -
        Flags: ui-review?(mmaslaney)

        Attachment #8587644 -
        Flags: ui-review?(philipp)

        Attachment #8587644 -
        Flags: ui-review?(mmaslaney)

        Attachment #8587644 -
        Flags: ui-review?(mmaslaney) → ui-review+

    
    

    
  
Comment on attachment 8587644 [details] [diff] [review]
new-newaddon-page.patch

Thank you Michael. ui-r from Philipp no more needed.

        Attachment #8587644 -
        Flags: ui-review?(philipp) → review?(dtownsend)

    
    

    
  


  
And again bit rot.

        Attachment #8587644 -
        Attachment is obsolete: true

        Attachment #8587644 -
        Flags: review?(dtownsend)

        Attachment #8588001 -
        Flags: review?(dtownsend)

        Attachment #8588001 -
        Flags: review?(dtownsend) → review+

    
    

    
  
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=db75c0d8278f

I don't think the Win bustage comes from this patch.
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/849d9c31cfca
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox40:
          --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla40

    
  
Depends on: 1247900

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: