Create a new test case for the deletion of video from Preview

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: njpark, Assigned: njpark)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.2 affected)

Details

(Whiteboard: fxosqa-auto-s4)

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

4 years ago
This bug is to automate https://moztrap.mozilla.org/manage/case/3324/ where it tests the deletion of the video that's just taken from the camera.
(Assignee)

Updated

4 years ago
Assignee: nobody → npark
status-b2g-v2.2: --- → affected
(Assignee)

Updated

4 years ago
Whiteboard: fxosqa-auto-s4
(Assignee)

Updated

4 years ago
No longer depends on: 1093874
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
Created attachment 8524750 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26263

initial attempt on automating https://moztrap.mozilla.org/manage/case/3324/
Attachment #8524750 - Flags: review?(zcampbell)
QA Whiteboard: [fxosqa-auto-backlog+]
(Assignee)

Comment 2

4 years ago
Comment on attachment 8524750 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26263

redirecting review per today's test automation meeting discussion
Attachment #8524750 - Flags: review?(zcampbell)
Attachment #8524750 - Flags: review?(viorela.ioia)
Attachment #8524750 - Flags: review?(florin.strugariu)
Comment on attachment 8524750 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26263

Comments in the PR
Attachment #8524750 - Flags: review?(viorela.ioia) → review-
Comment on attachment 8524750 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26263

It's a good very start.

It would have been nice for this to catch things like Bug 1105292 - Camera video preview goes blank after tapping play 

Let's update the code with the review changes and re-review this pull
Attachment #8524750 - Flags: review?(florin.strugariu) → review-
(Assignee)

Comment 5

4 years ago
Created attachment 8529504 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26263/files#r20940445

Incorporated all suggestions
Attachment #8524750 - Attachment is obsolete: true
Attachment #8529504 - Flags: review?(viorela.ioia)
Attachment #8529504 - Flags: review?(florin.strugariu)
Comment on attachment 8529504 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26263/files#r20940445

All looks ok but let's update the play pause logic
Attachment #8529504 - Flags: review?(florin.strugariu) → review-
(Assignee)

Comment 7

4 years ago
Created attachment 8529871 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26263/commits

recording time increased
Attachment #8529504 - Attachment is obsolete: true
Attachment #8529504 - Flags: review?(viorela.ioia)
Attachment #8529871 - Flags: review?(viorela.ioia)
Attachment #8529871 - Flags: review?(florin.strugariu)
Comment on attachment 8529871 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26263/commits

Some small nits and this is ready to merge
Attachment #8529871 - Flags: review?(florin.strugariu) → review-
Comment on attachment 8529871 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26263/commits

LGTM

Can we rebase this pull?
Attachment #8529871 - Flags: review- → review+
(Assignee)

Comment 10

4 years ago
Created attachment 8531771 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26615

I created a new branch with squashed commits for this.  Let me know if I need to correct anything.
Attachment #8529871 - Attachment is obsolete: true
Attachment #8529871 - Flags: review?(viorela.ioia)
Flags: needinfo?(florin.strugariu)
Comment on attachment 8531771 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26615

Looks OK to me

I will take a new look over the branch
Flags: needinfo?(florin.strugariu)
Attachment #8531771 - Flags: review?(viorela.ioia)
Attachment #8531771 - Flags: review?(florin.strugariu)
Comment on attachment 8531771 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26615

A few comments in the PR
Attachment #8531771 - Flags: review?(viorela.ioia) → review-
(Assignee)

Comment 13

4 years ago
Created attachment 8533210 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26615#issuecomment-66120514

Try test passed, and commits squashed
Attachment #8531771 - Attachment is obsolete: true
Attachment #8531771 - Flags: review?(florin.strugariu)
Attachment #8533210 - Flags: review?(viorela.ioia)
Attachment #8533210 - Flags: review?(florin.strugariu)
Comment on attachment 8533210 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26615#issuecomment-66120514

r+
Attachment #8533210 - Flags: review?(viorela.ioia) → review+
Attachment #8533210 - Flags: review?(florin.strugariu) → review+
merged in: https://github.com/mozilla-b2g/gaia/commit/d5e825754af73547972d20db782f6d420863ad25
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Blocks: 1111637
(Assignee)

Updated

4 years ago
Blocks: 1112227
(Assignee)

Updated

4 years ago
Blocks: 1112758
(Assignee)

Updated

4 years ago
No longer blocks: 1112758
(Assignee)

Updated

4 years ago
Blocks: 1112824
(Assignee)

Updated

4 years ago
No longer blocks: 1112824
You need to log in before you can comment on or make changes to this bug.