1111637 - Create a new test case for the switching to camera from gallery and back

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[No-Jun Park [:njpark]]

This bug is to automate https://moztrap.mozilla.org/manage/case/3620/ where it tests the app switching from camera app to gallery app

Comment 1

[No-Jun Park [:njpark]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26796

This script tests the app switching between gallery and camera.  While writing this test, I realized tests/endurance/test_endurance_gallery_camera.py is obsolete (and won't pass).  Should we trim these test cases?

Comment 2

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

I don't think we own the endurance tests--think that's Rob Wood's. Rob said something about those being deprecated at this point. I've NI'd him for more details.

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8536799 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26796

Some remarks and questions I added in the pull request.
I'm not saying I'm necessarily right with these questions, but if you could answer them (or Florin), then I'm fine.

Comment 4

[Florin Strugariu [:Bebe]]

Comment on attachment 8536799 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26796

some small nit's

Comment 5

[No-Jun Park [:njpark]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26796

Comments are incorporated

Comment 6

[Robert Wood [:rwood]]

Yes that is correct, at this point the endurance tests are not being maintained or expanded.

IMO to have any real value, they would need to be overhauled drastically. i.e. Besides updating to work with the latest gaia changes, the test framework should use the get_about_memory tool to grab memory info for each app (instead of just b2g-ps and using the RSS value for the main b2g process), re-evaluate the usefulness of each test, force garbage collection first, etc. So this would be potentially be a large project. Also, there may be other tests already running that provide more value, even if these tests were overhauled (i.e. the *_memory tests that are posting to DataZilla).

Most of the endurance tests were developed from existing functional gaia-ui tests, which are still running.

Comment 7

[No-Jun Park [:njpark]]

Try server result:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=85a923e9f638

Comment 8

[No-Jun Park [:njpark]]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #3)
> Comment on attachment 8536799 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26796
> 
> Some remarks and questions I added in the pull request.
> I'm not saying I'm necessarily right with these questions, but if you could
> answer them (or Florin), then I'm fine.

All of your comments are incorporated in the latest fix

Comment 9

[Martijn Wargers (dead)]

Comment on attachment 8537250 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26796

Two small nits that need to be fixed (found with pep8, you should use that too on files you change), but it looks great to me.
I run it locally 10 times without failures.

Comment 10

[Florin Strugariu [:Bebe]]

Comment on attachment 8537250 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26796

Let's fix those 2 PEP8 nits

Comment 12

[No-Jun Park [:njpark]]

Will squash commits and let you know once the try results are posted

Comment 13

[No-Jun Park [:njpark]]

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=fbacd577f93f

result is good now, ready to be merged

Comment 14

[Florin Strugariu [:Bebe]]

No-Jun it looks like you have some issues with the commit :(

https://github.com/mozilla-b2g/gaia/pull/26796/commits

Github says:  viorelaioia authored 3 days ago npark-mozilla committed 22 hours ago 

Is it OK to merge it like this?

The code is looks good and ready to merge

Comment 15

[No-Jun Park [:njpark]]

i think it happened when i fetched the master and squashed commits, it took the author name of first diff of new master if I can guess correctly.  But code itself is okay.  If this is an issue and you need me to create a new branch and manually copy over the code changes, let me know.

Comment 16

[Florin Strugariu [:Bebe]]

After IRC talk merged: https://github.com/mozilla-b2g/gaia/commit/09618e086b2723ab5fa3b9af9da04c4a2fccb497