1100689 - [Flatfish][Setting] Box overflow at volume options

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Raniere Silva]

Attachment: Screenshot with overflow

Box need more spaces (see attachment).

Comment 1

[YF (Yang)]

Attachment: just hide it

Following the previous setting (background: none;).

Feel free to submit a better patch or bug to do the right icon positioning.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8524321 [details] [review]
just hide it

ah .. I think we can't just hide it because the icon is also part of spec. Can we still keep the same design as phone and put the icon on the left of the slider instead ? 

THanks !

Comment 3

[YF (Yang)]

(In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #2)
> Comment on attachment 8524321 [details] [review]
> just hide it
> 
> ah .. I think we can't just hide it because the icon is also part of spec.
> Can we still keep the same design as phone and put the icon on the left of
> the slider instead ? 
> 
> THanks !

I see that we've done so previous, the background: url icon be background: none; in settings_large.css.

We really do need to spend energy to achieve this? we currently don't have any icon in the sound subpanel, it is not aligned if the icons are placed on the left.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master(2.2)

This patch makes slider CSS more cleaner and would not hide icons in sound panel.

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to YF (Yang) from comment #3)
> (In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #2)
> > Comment on attachment 8524321 [details] [review]
> > just hide it
> > 
> > ah .. I think we can't just hide it because the icon is also part of spec.
> > Can we still keep the same design as phone and put the icon on the left of
> > the slider instead ? 
> > 
> > THanks !
> 
> I see that we've done so previous, the background: url icon be background:
> none; in settings_large.css.
> 
> We really do need to spend energy to achieve this? we currently don't have
> any icon in the sound subpanel, it is not aligned if the icons are placed on
> the left.

I still think it make more sense to show icons as what we did in phone. I'll ask UI's help to feedback on this bug by the way :)

@Helen, can you give us some UI feedback on this patch ?! For my personal opinion, I think icons should be shown on sound panel as what we did in phone. Any feedback would be appreciated ;)

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: with-patch.png

This is the screenshot for tablet with my patch.

Comment 7

[YF (Yang)]

(In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #6)
> Created attachment 8525941 [details]
> with-patch.png
> 
> This is the screenshot for tablet with my patch.

Looks okay, I forgot that it can be placed on the right side of the text.

The ringtones icon maybe not be suitable for tablet devices.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8525939 [details] [review]
patch on master(2.2)

Arthur, this is the bug I told you which focusing on fixing layout problems in Settings app when using tablet.

Please help me review this patch when you have time, thanks ! :)

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8525939 [details] [review]
patch on master(2.2)

r=me with what we discussed. Please remove the icons and adjust the position of the icons in the display panel, thanks.

Comment 10

[Helen Huang [:HHuang]]

Hi EJ, thanks for your effort on this, but those icons seems a bit weird in current layout, so I propose removing the icons on sound panel for tablet. Thank you!

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Helen Huang from comment #10)
> Hi EJ, thanks for your effort on this, but those icons seems a bit weird in
> current layout, so I propose removing the icons on sound panel for tablet.
> Thank you!

OK thanks Helen !

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, this patch just got merged into Gaia/master (2.2) :

https://github.com/mozilla-b2g/gaia/commit/593a59b57ca057fa9d0ec71f2940dd6168430cb0