1100893 - [Contacts][RTL] Switch for facebook sync is wrong in RTL languages

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: 2014-11-18-11-31-42.png

STR:
1. Setup a RTL language
2. Be sure you have connectivity (wifi or 3g)
3. Go to contacts
4. Click on settings

Actual:
- Switch to enable fb sync is on the right overlaping the text.

Expected:
- Switch to enable facebook sync is on the left

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 26493

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Fb settings with patch applied v1

Comment 3

[Fang Shih [:fang]]

Comment on attachment 8529202 [details]
Fb settings with patch applied v1

Looks good, Only the switch button should be left aligned with the edge of the action button. Thanks!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Ei Fang,

Actually I made that to not to align with the edge of the action button cause in master is like that.

So I'll change both RTL and LTR cases to be aligned in the same way.

Comment 5

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

What's with the enlarged FB button? It looks scaled out.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Sergi Mansilla [:sergi] (Telenor) from comment #5)
> What's with the enlarged FB button? It looks scaled out.

Hei Sergi, I was following master as base and was that size too. Perhaps we have a bug on that screen in master.

Comment 7

[Jose Manuel Cantera]

hi,

are you aware of this bug 1076701 ? It should be landing very soon ...

Comment 8

[Jose Manuel Cantera]

(In reply to Jose Manuel Cantera from comment #7)
> hi,
> 
> are you aware of this bug 1076701 ? It should be landing very soon ...

wrong one this bug 1078174

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Jose Manuel Cantera from comment #8)
> (In reply to Jose Manuel Cantera from comment #7)
> > hi,
> > 
> > are you aware of this bug 1076701 ? It should be landing very soon ...
> 
> wrong one this bug 1078174

Better to wait till that bug lands

Comment 10

[Stephany Wilkes]

Francisco, can you/do you need to revisit your patch based on bug #1078174 having landed? 

Fang, since bug #1078174 has landed (and based on Francisco's response to whether or not his patch needs to be revisited), can you revisit the ui-review flag here and see if it makes +? Thanks!

Comment 11

[Fang Shih [:fang]]

Attachment: RTL_contact_settings.jpg

I've checked the latest build. Everything looks fine. The only issue here is the switch button of "Facebook sync friends" is not in RTL position. I've attached the screenshot. Let me know if you need anything. Thanks!

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

I will wait till bug 1116803 lands, during the review of this one I saw this correctly.

Comment 13

[Dylan Oliver [:doliver]]

RTL triage: P2 -- will make a best effort to get this into the 2.2 release.

Comment 14

[Dylan Oliver [:doliver]]

RTL update: marking required bugs as feature-b2g:2.2+ (and removing blocking flags)

Comment 15

[Fang Shih [:fang]]

Comment on attachment 8529202 [details]
Fb settings with patch applied v1

I've checked in the patch from bug 1116803, the switch button has been solved. Thanks!

Comment 16

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8529200 [details] [review]
Pointer to PR 26493

Hi Sergi, since the adjustments in contacts settings already landed, here is the updated patch.

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8529200 [details] [review]
Pointer to PR 26493

Changing the review to Jose since Sergi is a bit overloaded

Comment 18

[Jose Manuel Cantera]

Comment on attachment 8529200 [details] [review]
Pointer to PR 26493

LGTM

thanks

Comment 19

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/7ea744c4755c8471e8b91a90c93de7672c25e7e4

Comment 20

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8529200 [details] [review]
Pointer to PR 26493

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
RTL bug
[User impact] if declined:
Bad user experience in RTL
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 21

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/4d30c3ab3f23247483a9d5ae4368b26a67ea3784

Comment 22

[Coler]

This issue has been verified successfully on Flame 2.0/3.0.
Reproduce rate:0/5
Attachment:Verify_RTL_Contact.png

Flame 2.2 build:

Build ID               20150204002509
Gaia Revision          a4c4cc86303a554facb8f45b7e764e5c4473c3de
Gaia Date              2015-02-04 00:41:59
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8669c26fd4a5
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150204.035932
Firmware Date          Wed Feb  4 03:59:42 EST 2015
Bootloader             L1TC000118D0

Flame 3.0 build:

Build ID               20150204010225
Gaia Revision          dfebaaa8aab43470f482d09d71137bab840c3ae9
Gaia Date              2015-02-03 18:49:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0c2f7434c325
Gecko Version          38.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150204.043856
Firmware Date          Wed Feb  4 04:39:07 EST 2015
Bootloader             L1TC000118D0

Comment 23

[Coler]

Attachment: Verify_RTL_Contact.png