1101190 - Remove new tablet edit_cancel button

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Don't need that.

Comment 1

[Lucas Rocha (:lucasr)]

What asset are you referring to here?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/newtablet/res/layout-large-v11/new_tablet_browser_toolbar.xml?rev=75599db3d71d#100

The view with id=edit_cancel is defined in with visibility="gone" on new tablet because we use editCancel in BrowserToolbar - the reference should be moved to old tablet, and phone only. Note that the code change would be simplified if we wait until the old tablet code is removed, where just phone is needed (i.e. no code duplication).

Comment 3

[Lucas Rocha (:lucasr)]

Ok, I'm moving this to v2 then.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Might be taken care of as part of bug 1106935.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.