Move tree utilities out of profiler

RESOLVED FIXED in Firefox 38

Status

()

Firefox
Developer Tools: Performance Tools (Profiler/Timeline)
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jsantell, Assigned: jsantell)

Tracking

36 Branch
Firefox 38
Points:
---

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

These utility modules should be moved out of profiler and into shared for use outside of profiler (specifically, new performance tools)
(Assignee)

Updated

3 years ago
Assignee: nobody → jsantell
Created attachment 8524945 [details] [diff] [review]
1101235-move-profiler-utils.patch

We'll be using these in new performance tool, so let's keep them alive and not duplicated moving them to shared.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=4e4dc8effd11
Attachment #8524945 - Flags: review?(vporof)
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Blocks: 1077451
Comment on attachment 8524945 [details] [diff] [review]
1101235-move-profiler-utils.patch

Review of attachment 8524945 [details] [diff] [review]:
-----------------------------------------------------------------

Instead of deleting and creating a new files, please use `hg move` to retain commit history. Also, why not simply move them inside the new performance folder, instead of shared? Once this new tool is finished, it is very unlikely that we'll ever use those files outside this new tool.
Attachment #8524945 - Flags: review?(vporof) → review-
Created attachment 8562454 [details] [diff] [review]
1101235-migrate-profiler.patch

This took longer than I'd like, but it was all in hg for the move stuff. Tests pass locally for perf/timeline/profiler/shared, so hopefully try says the same. Might not be the most perfect location for these utils, but they are shared between several modules at the moment, and this will get us moving forward on the gum builds.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b5369aa8bb2
Attachment #8524945 - Attachment is obsolete: true
Attachment #8562454 - Flags: review?(vporof)
Comment on attachment 8562454 [details] [diff] [review]
1101235-migrate-profiler.patch

Review of attachment 8562454 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/test/browser.ini
@@ +76,5 @@
> +[browser_profiler_tree-view-03.js]
> +[browser_profiler_tree-view-04.js]
> +[browser_profiler_tree-view-05.js]
> +[browser_profiler_tree-view-06.js]
> +[browser_profiler_tree-view-07.js]

Let's move all the tests inside the new perf tool. We can keep the widgets themselves and in this shared folder (for now), but no sense having the tests here, since we're going to move everything inside the performance folder at a later date anyway.
Attachment #8562454 - Flags: review?(vporof) → review+
Created attachment 8562988 [details] [diff] [review]
1101235-migrate-profiler.patch

Moved tests from shared/ to performance/, retested locally
Attachment #8562454 - Attachment is obsolete: true
Attachment #8562988 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/d7ce14fb3ee9
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d7ce14fb3ee9
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
You need to log in before you can comment on or make changes to this bug.