Closed Bug 1101655 Opened 5 years ago Closed 5 years ago

[mozdevice] Support the ADB server running on an alternate host/port

Categories

(Testing :: Mozbase, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: davehunt, Assigned: davehunt)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently all of our ADB calls assume that we want to execute them on localhost:5037 (the defaults), however we now have a need to run them on a remote server. I would like to add server host/port arguments when instantiating an ADB device manager.
Blocks: 1102140
Comment on attachment 8525984 [details] [diff] [review]
Support the ADB server running on an alternate host/port. v1.0

Review of attachment 8525984 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good except for the variable naming. Assuming it works since I haven't tested it. :)

::: testing/mozbase/mozdevice/mozdevice/devicemanagerADB.py
@@ +42,5 @@
>          self.host = host
>          self.port = port
>          self.retryLimit = retryLimit
>  
> +        self.server_host = server_host

We should use camel case for variable names, following the style elsewhere in the file.
Attachment #8525984 - Flags: review?(wlachance) → review+
Uses camel case, and removes the defaults of localhost and 5037. By specifying these it stopped ADB from starting the daemon locally and assumed it was already running.

Try:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ba879872ea10
Attachment #8525984 - Attachment is obsolete: true
Attachment #8528480 - Flags: review?(wlachance)
Attachment #8528480 - Flags: review?(wlachance) → review+
https://hg.mozilla.org/mozilla-central/rev/8887aaafa0c3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.