1101655 - [mozdevice] Support the ADB server running on an alternate host/port

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Currently all of our ADB calls assume that we want to execute them on localhost:5037 (the defaults), however we now have a need to run them on a remote server. I would like to add server host/port arguments when instantiating an ADB device manager.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Support the ADB server running on an alternate host/port. v1.0

Try:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8d776fbc595a

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8525984 [details] [diff] [review]
Support the ADB server running on an alternate host/port. v1.0

Review of attachment 8525984 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good except for the variable naming. Assuming it works since I haven't tested it. :)

::: testing/mozbase/mozdevice/mozdevice/devicemanagerADB.py
@@ +42,5 @@
>          self.host = host
>          self.port = port
>          self.retryLimit = retryLimit
>  
> +        self.server_host = server_host

We should use camel case for variable names, following the style elsewhere in the file.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Support the ADB server running on an alternate host/port. v2.0

Uses camel case, and removes the defaults of localhost and 5037. By specifying these it stopped ADB from starting the daemon locally and assumed it was already running.

Try:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ba879872ea10

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8887aaafa0c3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8887aaafa0c3