Closed Bug 1101497 Opened 11 years ago Closed 11 years ago

Support connecting to a remote ADB host

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed, b2g-v2.0M fixed, b2g-v2.1 affected, b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla37
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.0M --- fixed
b2g-v2.1 --- affected
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: davehunt, Assigned: davehunt)

References

Details

Attachments

(3 files, 3 obsolete files)

Support the ADB server running on an alternate host/port. v1.0
9.12 KB, patch
mdas
: review+
Details | Diff | Splinter Review
Uplift for mozilla-b2g34_v2_1
10.10 KB, patch
jgriffin
: review+
Details | Diff | Splinter Review
Uplift mozbase changes to mozilla-b2g32_v2_0
22.56 KB, patch
jgriffin
: review+
Details | Diff | Splinter Review
In order to run tests against remote devices we need to be able to specify the host/port that ADB is listening on. The host will always be the same as the Marionette host, so we can probably just reuse that, but the port will be a unique value.
Depends on: 1101655
Depends on: 1102140
Depends on: 1105995
Comment on attachment 8535077 [details] [diff] [review] Support the ADB server running on an alternate host/port. v1.0 Review of attachment 8535077 [details] [diff] [review]: ----------------------------------------------------------------- r+ provided that this was tested locally against bitbar.
Attachment #8535077 - Flags: review?(mdas) → review+
https://hg.mozilla.org/mozilla-central/rev/6468fd2f5aa6
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Attached file Uplift for mozilla-b2g32_v2_0 (obsolete) —
We need this for mozilla-b2g32_v2_0 so the Marketplace tests can run against our remote device lab. I've tested this using a locally built client and have successfully run the tests on our remote lab.
Attachment #8572001 - Flags: review?(jgriffin)
Attached patch Uplift for mozilla-b2g32_v2_0 (obsolete) — — Splinter Review
Previous patch had an issue when generating the HTML report, which is addressed in this patch.
Attachment #8572001 - Attachment is obsolete: true
Attachment #8572001 - Flags: review?(jgriffin)
Attachment #8572054 - Flags: review?(jgriffin)
Attached patch Uplift for mozilla-b2g34_v2_1 (obsolete) — — Splinter Review
Attachment #8572055 - Flags: review?(jgriffin)
Corrected commit message and bumped version number.
Attachment #8572055 - Attachment is obsolete: true
Attachment #8572055 - Flags: review?(jgriffin)
Attachment #8572060 - Flags: review?(jgriffin)
Comment on attachment 8572054 [details] [diff] [review] Uplift for mozilla-b2g32_v2_0 Review of attachment 8572054 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #8572054 - Flags: review?(jgriffin) → review+
Attachment #8572060 - Flags: review?(jgriffin) → review+
Depends on: 1139461
Updated patch to include necessary uplifts from bug 1101655, bug 1102140, and bug 1101497. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=40434762b8b7 I'm not expecting a completely clear try run. The Gip tests will fail because of the marionette-client package name change (which will land at the same time as this patch). Also see bug 1139461 comment 27 and the response regarding other expected failures.
Attachment #8572054 - Attachment is obsolete: true
Flags: needinfo?(dave.hunt)
Attachment #8580627 - Flags: review?(jgriffin)
(In reply to Dave Hunt (:davehunt) from comment #13) > I'm not expecting a completely clear try run. The Gip tests will fail > because of the marionette-client package name change (which will land at the > same time as this patch). Also see bug 1139461 comment 27 and the response > regarding other expected failures. Please ignore the Gip failure comment, I was mixing this up with bug 1141590. I am expecting the Gip tests to pass on try.
RyanVM: Would you mind looking over https://treeherder.mozilla.org/#/jobs?repo=try&revision=40434762b8b7 and comment if there are any concerns? I see some jobs haven't completed yet...
Flags: needinfo?(ryanvm)
lgtm
Flags: needinfo?(ryanvm)
Comment on attachment 8580627 [details] [diff] [review] Uplift mozbase changes to mozilla-b2g32_v2_0 Review of attachment 8580627 [details] [diff] [review]: ----------------------------------------------------------------- lgtm, thanks to ryan for blessing the try run :)
Attachment #8580627 - Flags: review?(jgriffin) → review+
Landed in: https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/8e0185659915 Build: https://treeherder.mozilla.org/#/jobs?repo=mozilla-b2g32_v2_0&revision=8e0185659915 I'll watch Treeherder, and once I can confirm no bustage I will re-release the Python package.
Flags: needinfo?(dave.hunt)
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: