mail/installer/package-manifest.in needs to be updated after the cleanup in bug 1096494

RESOLVED FIXED in Thunderbird 36.0

Status

Thunderbird
Installer
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: spohl, Assigned: spohl)

Tracking

unspecified
Thunderbird 36.0
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird36 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
+++ This bug was initially created as a clone of Bug #1096494 +++

Unfortunately, I didn't realize that the patch in bug 1096494 would bust comm-central on OSX. All that seems to be necessary is for mail/installer/package-manifest.in to use @RESPATH@ instead of @BINPATH@ for the resources that are located under Contents/Resources. The patch in bug 1096494 should be a good illustration how this was done for Firefox.

Josiah, since you've handled most of the v2 signing changes for TB, is this something that you could tackle? Happy to assist with feedback or anything else that would be helpful.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Yes, that's fine. Thanks for filing the bug!
Assignee: nobody → josiah
Status: NEW → ASSIGNED
(Assignee)

Comment 4

4 years ago
Created attachment 8526098 [details] [diff] [review]
Patch

Thanks, Josiah! I actually found some time this morning to write the patch myself. I hope you didn't get started yet. Thanks for offering your help though!
Assignee: josiah → spohl.mozilla.bugs
Attachment #8526098 - Flags: review?(Pidgeot18)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment on attachment 8526098 [details] [diff] [review]
Patch

Review of attachment 8526098 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh, I wish packaging were more sane. I pushed this to try and it passed tests at least as well as anything else these days, and I don't see anything that stands out as weird or wrong, so r+.
Attachment #8526098 - Flags: review?(Pidgeot18) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 8

4 years ago
Not sure how approvals etc. work on comm-central, and it's getting too late here to watch the tree. Setting checkin-needed in the hope that this keyword applies to comm-central too.

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
status-thunderbird36: --- → fixed
You need to log in before you can comment on or make changes to this bug.