package-manifest.in needs to be updated after the cleanup in bug 1096494

RESOLVED FIXED in 1.6

Status

Instantbird
Other
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: spohl, Assigned: spohl)

Tracking

trunk
All
Mac OS X

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
+++ This bug was initially created as a clone of Bug #1096494 +++

Unfortunately, I didn't realize that the patch in bug 1096494 would bust comm-central on OSX. I'm assuming this also affects Instantbird. All that seems to be necessary is for package-manifest.in to use @RESPATH@ instead of @BINPATH@ for the resources that are located under Contents/Resources. The patch in bug 1096494 should be a good illustration how this was done for Firefox.

I'd usually write this patch myself, but I'm currently sidetracked with getting a Firefox hotfix out the door. I'll still write the patch if nobody else gets to this first.
Component: General → Other
Product: Chat Core → Instantbird
(Assignee)

Comment 1

4 years ago
Created attachment 8526082 [details] [diff] [review]
Patch

Florian, I see that you reviewed the patch in bug 1079220, so I'm hoping you're the right person to ask for a review here.
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Attachment #8526082 - Flags: review?(florian)
Comment on attachment 8526082 [details] [diff] [review]
Patch

I would usually be the right person for this, but I won't have time today and this looks like a bustage fix that should be taken care of sooner than later, moving the flag to Patrick.
Attachment #8526082 - Flags: review?(florian) → review?(clokep)
Comment on attachment 8526082 [details] [diff] [review]
Patch

Tested this locally and it worked fine. Looks sane too. Thanks!
Attachment #8526082 - Flags: review?(clokep) → review+
Pushed. I'll restart the Mac nightly to ensure it works there too.

https://hg.mozilla.org/comm-central/rev/f34852855b37
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.