1102130 - New Loop rooms sound files missing from desktop

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Bug 1088650 added new sounds files for the rooms, however, I forgot to add them to the jar.mn file, so we should add them.

Comment 1

[Mark Banner (:standard8)]

Attachment: [checked in] New Loop rooms sound files missing from desktop.

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8525876 [details] [diff] [review]
[checked in] New Loop rooms sound files missing from desktop.

Review of attachment 8525876 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/0e0ea79db23a

Comment 4

[Mark Banner (:standard8)]

Attachment: Followup - fix sound names of files for Loop rooms

I messed up the spelling of .ogg in the first patch, this patch corrects it, I can't land atm as the tree is closed.

Comment 5

[Mark Banner (:standard8)]

Note - commit comment in the file (rs=abr over irc)

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/fx-team/rev/c2dc7bfcf956

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0e0ea79db23a

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c2dc7bfcf956

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8525876 [details] [diff] [review]
[checked in] New Loop rooms sound files missing from desktop.

For both patches: 

Approval Request Comment
[Risks and why]: Loop rooms code needed for 35 pref-on
[String/UUID change made/needed]: none

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dc05d0895096
https://hg.mozilla.org/releases/mozilla-aurora/rev/d48884d6bfac