Closed Bug 1102130 Opened 10 years ago Closed 10 years ago

New Loop rooms sound files missing from desktop

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox35 fixed, firefox36 fixed)

RESOLVED FIXED
mozilla36
Iteration:
36.3
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
backlog Fx35+

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

Bug 1088650 added new sounds files for the rooms, however, I forgot to add them to the jar.mn file, so we should add them.
Comment on attachment 8525876 [details] [diff] [review]
[checked in] New Loop rooms sound files missing from desktop.

Review of attachment 8525876 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8525876 - Flags: review?(nperriault) → review+
https://hg.mozilla.org/integration/fx-team/rev/0e0ea79db23a
Iteration: --- → 36.3
Target Milestone: --- → mozilla36
Priority: -- → P1
Whiteboard: [checkin needed for follow-up patch]
I messed up the spelling of .ogg in the first patch, this patch corrects it, I can't land atm as the tree is closed.
Attachment #8525876 - Attachment description: New Loop rooms sound files missing from desktop. → [checked in] New Loop rooms sound files missing from desktop.
Note - commit comment in the file (rs=abr over irc)
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/c2dc7bfcf956
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8525876 [details] [diff] [review]
[checked in] New Loop rooms sound files missing from desktop.

For both patches: 

Approval Request Comment
[Risks and why]: Loop rooms code needed for 35 pref-on
[String/UUID change made/needed]: none
Attachment #8525876 - Flags: approval-mozilla-aurora?
Attachment #8526324 - Flags: approval-mozilla-aurora?
Attachment #8525876 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8526324 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify-
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.