Closed Bug 1088650 Opened 5 years ago Closed 5 years ago

Desktop client needs sounds for the rooms implementation

Categories

(Hello (Loop) :: Client, defect, P1)

x86_64
Windows 8
defect
Points:
3

Tracking

(firefox35 fixed, firefox36 fixed)

RESOLVED FIXED
mozilla36
Iteration:
36.3
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
Blocking Flags:
backlog Fx35+

People

(Reporter: RT, Assigned: standard8)

References

Details

(Whiteboard: [rooms])

Attachments

(1 file)

This bug lists all sounds required on the desktop client UI for FF35 implementation. Here are the sound files with reference to the UX matching the time these sounds need to be played
* Direct call - Connecting:
     - Sound file: https://www.dropbox.com/sh/0fvz9cead5bt8zj/AAAsLfYFAN5oYKcM1YHwVMLta/Call%20Progress%204%20-%20Personality.wav?dl=0
     - UX reference (Connecting stage - sound played on caller end only): https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#call-outgoing
* Direct call - Ringback:
     - Sound file: https://www.dropbox.com/sh/0fvz9cead5bt8zj/AADJS41VZmL2wbqjxgmIpa0Xa/Ringback-1.wav?dl=0
https://bugzilla.mozilla.org/show_bug.cgi?id=1015077
     - UX (Ringing stage - sound played on caller end only): https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#call-outgoing
* Direct call - Call connected:
     - Sound file: https://www.dropbox.com/sh/0fvz9cead5bt8zj/AAAbsYf6TGikHqe4CrbTL3nka/C1-Connect-Up.wav?dl=0 
     - UX (play sound once the call connects - sound played on both the callee and the caller sides): https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#call-active
* Direct call - Call failed:
     - Sound file: https://www.dropbox.com/sh/0fvz9cead5bt8zj/AACr5DNQprNBz8IUUc6VSvt8a/C1-Failed.wav?dl=0Callee
     - UX (play sound when an outgoing call fails to connect to the other peer and the UX prompts the user to share a call-back link - sound played on the caller end only): https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#link-prompt
* Direct call - Call terminated:
     - Sound file: https://www.dropbox.com/sh/0fvz9cead5bt8zj/AAB1IQu3AladsKfZhBsC3oA-a/C1-Disconnect-Down.wav?dl=0 
     - UX (Play sound when the call terminates and the user gets displayed the feedback form - sound played on both the caller and the callee sides): https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#feedback
* Direct call - Incoming call notification:
     - Sound file: https://www.dropbox.com/sh/0fvz9cead5bt8zj/AAAxehbnSWO-6njIG12I90nca/Ringtone-Full.wav?dl=0 
     - UX (Play sound file upon incoming call notification screen as a result of a direct call or a URL call-back - sound played on the callee side only): https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#call-incoming
* Rooms - Someone joined a room you own notification (when you are not in the room) 
      - Sound file: https://www.dropbox.com/sh/0fvz9cead5bt8zj/AAB1SvGo92oDVrDF4rUo4rEXa/G1-Connect-High.wav?dl=0 
* Rooms - Room creator joins a room he created
      - Sound file: https://www.dropbox.com/sh/0fvz9cead5bt8zj/AAAbsYf6TGikHqe4CrbTL3nka/C1-Connect-Up.wav?dl=0 
* Rooms - Someone joins a room you are already in 
      - Sound file: https://www.dropbox.com/sh/0fvz9cead5bt8zj/AAAbsYf6TGikHqe4CrbTL3nka/C1-Connect-Up.wav?dl=0 
* Rooms - Other person leave a room when the creator is still in the room
      - Sound file: https://www.dropbox.com/sh/0fvz9cead5bt8zj/AAB1IQu3AladsKfZhBsC3oA-a/C1-Disconnect-Down.wav?dl=0
backlog: --- → Fx35+
Priority: -- → P1
Whiteboard: [rooms]
See Also: → 1099186
Assignee: nobody → standard8
This adds the sounds for both desktop (this bug) and standalone (bug 1088659).

I've gone with making the sounds the same on both - as this seems best from consistent UX purposes.
Attachment #8524659 - Flags: review?(nperriault)
Blocks: 1088659
Iteration: --- → 36.3
Points: --- → 3
Comment on attachment 8524659 [details] [diff] [review]
Add sounds for notifications when rooms are joined, left or if there are failures.

Review of attachment 8524659 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I think the patch could benefit from applying AudioMixin to RoomsAudioMixin directly, see this revisited version of the patch: http://pastebin.mozilla.org/7365918. Your call :)

::: browser/components/loop/content/js/roomViews.jsx
@@ +136,5 @@
> +    mixins: [
> +      ActiveRoomStoreMixin,
> +      sharedMixins.DocumentTitleMixin,
> +      sharedMixins.AudioMixin,
> +      sharedMixins.RoomsAudioMixin

AudioMixin could be applied directly in RoomAudioMixin.

::: browser/components/loop/content/shared/js/mixins.js
@@ +229,5 @@
> +  /**
> +   * A mixin especially for rooms. This plays the right sound according to
> +   * the state changes. Requires AudioMixin to also be used.
> +   */
> +  var RoomsAudioMixin = {

I mean here:

  mixins: [AudioMixin],

::: browser/components/loop/standalone/content/js/standaloneRoomViews.jsx
@@ +143,5 @@
>    var StandaloneRoomView = React.createClass({
> +    mixins: [
> +      Backbone.Events,
> +      sharedMixins.AudioMixin,
> +      sharedMixins.RoomsAudioMixin

Same remark as above.
Attachment #8524659 - Flags: review?(nperriault) → review+
https://hg.mozilla.org/integration/fx-team/rev/6b62902f888b
Target Milestone: --- → mozilla36
https://hg.mozilla.org/mozilla-central/rev/6b62902f888b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Flags: qe-verify-
Flags: in-testsuite?
Comment on attachment 8524659 [details] [diff] [review]
Add sounds for notifications when rooms are joined, left or if there are failures.

Approval Request Comment

requirement for Loop Rooms support for Aurora/35
On m-c; testing with rooms server changes now live in production

[String/UUID change made/needed]: none
Attachment #8524659 - Flags: approval-mozilla-aurora?
Depends on: 1102130
Attachment #8524659 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.