1102160 - [Settings][RTL] Back button on Sound Settings panel header is inverted

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Bruce Huang [:bhuang] (inactive)]

The back button on the header of the Sound settings panel is mirrored and then inverted.  Might be covered in bug 1102150, but currently it behaves differently from all other panels.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/26393

EJ, please help review the simple patch, thanks!

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8527471 [details]
link to https://github.com/mozilla-b2g/gaia/pull/26393

r+, thanks Arthur !! :)

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, EJ.

master: a50955b336bf9dd416b2679946431c8eb240f054

Comment 4

[Delphine Lebédel]

Verified and bug is fixed, thus closing this one

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8527471 [details]
link to https://github.com/mozilla-b2g/gaia/pull/26393

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/!
[User impact] if declined: Leads to bad user experience
[Testing completed]: Testing on the device
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: N/A

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This was fixed back in November, 2 months before v2.2 branched. What exactly is being uplifted here?

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

oh, my mistake...