Closed
Bug 1102185
Opened 9 years ago
Closed 9 years ago
[FFOS2.0][Woodduck][STK]There has no terminal response when execute "setup call ->cancel".
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)
Firefox OS Graveyard
Gaia::Dialer
Tracking
(blocking-b2g:2.0M+, b2g-v2.0 wontfix, b2g-v2.0M fixed, b2g-v2.1 fixed, b2g-v2.1S fixed, b2g-v2.2 fixed)
People
(Reporter: selee, Assigned: selee)
References
Details
Attachments
(3 files)
The previous bug description is pasted at the bottom. Here is the summary for the current status: 1. Users go to a option for STK_CMD_SET_UP_CALL. 2. When the call screen is shown, there is a TR 0x10 (STK_RESULT_UICC_SESSION_TERM_BY_USER) sent. 3. The TR(0x10) should not be sent. We found function stkResTerminate (system/js/icc.js) sends STK_RESULT_UICC_SESSION_TERM_BY_USER when event "visibilitychange" is triggered.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → selee
Assignee | ||
Comment 1•9 years ago
|
||
Hello Fernando, Arthur, Here is my PR for this bug. Please help to review it. Thank you. 1. Clear the event of onVisibilityChange when any option is clicked. 2. Redirect visibilityChange of Settings to System app. System app handles the event is a better strategy. 3. Add test case to handle on visibility change event from Settings app.
Attachment #8525967 -
Flags: review?(frsela)
Attachment #8525967 -
Flags: review?(arthur.chen)
Comment 3•9 years ago
|
||
Comment on attachment 8525967 [details] [review] Pull Request The direction looks good to me. I left some comments in github regarding the naming. Please check, thanks!
Attachment #8525967 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 4•9 years ago
|
||
Hi Arthur, The patch is updated. Please help to see the changes. Thank you.
Flags: needinfo?(arthur.chen)
Comment 5•9 years ago
|
||
Comment on attachment 8525967 [details] [review] Pull Request LGTM. Asking Manuel for testing in a real device
Attachment #8525967 -
Flags: review?(frsela)
Attachment #8525967 -
Flags: review+
Attachment #8525967 -
Flags: feedback?(b.mcb)
Updated•9 years ago
|
blocking-b2g: --- → 2.0M+
status-b2g-v2.0:
--- → affected
status-b2g-v2.0M:
--- → affected
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → affected
Updated•9 years ago
|
Blocks: Woodduck_Blocker
Comment 6•9 years ago
|
||
Comment on attachment 8525967 [details] [review] Pull Request Looks good, thanks!
Flags: needinfo?(arthur.chen)
Attachment #8525967 -
Flags: review+
Assignee | ||
Comment 7•9 years ago
|
||
Hello Arthur, Fernando, Thank you!! gaia-try PASS: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=4e3698d1d1b2 landed on https://github.com/mozilla-b2g/gaia/commit/80bc1445959db79e9d2e947cc56e1eb7b0d3d0f0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 8•9 years ago
|
||
Comment on attachment 8525967 [details] [review] Pull Request Works fine on device! Thanks for the patch
Attachment #8525967 -
Flags: feedback?(b.mcb) → feedback+
Comment 10•9 years ago
|
||
Uplift to 2.0m get conflicts in apps/system/js/icc.js.
Flags: needinfo?(selee)
Keywords: branch-patch-needed
Assignee | ||
Comment 11•9 years ago
|
||
Flags: needinfo?(selee)
Updated•9 years ago
|
Blocks: Woodduck_P2
Updated•9 years ago
|
No longer blocks: Woodduck_P2
Updated•9 years ago
|
Blocks: Woodduck_P2
Updated•9 years ago
|
No longer blocks: Woodduck_P2
Comment 12•9 years ago
|
||
v2.0m: https://github.com/mozilla-b2g/gaia/commit/6d0819237dedee9d2092a8a117b7ad590f4bcd1b
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8525967 [details] [review] Pull Request This patch can provide better STK user experience in FxOS. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: STK feature will be abnormal if the visibility behavior is not fixed. [Testing completed]: 1. Implement Unit Test and test PASS. 2. Partner tested PASS in their LAB. (see bug 1093993) [Risk to taking this patch] (and alternatives if risky): [String changes made]:
Attachment #8525967 -
Flags: approval-gaia-v2.1?
Updated•9 years ago
|
Attachment #8525967 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Comment 15•9 years ago
|
||
Assignee | ||
Comment 16•9 years ago
|
||
v2.1: https://github.com/mozilla-b2g/gaia/commit/dd28f69928cd832be352b6c3ea300993a9c0a845
Updated•9 years ago
|
status-b2g-v2.1S:
--- → fixed
Updated•9 years ago
|
Keywords: branch-patch-needed
Target Milestone: --- → 2.2 S1 (5dec)
You need to log in
before you can comment on or make changes to this bug.
Description
•