1102185 - [FFOS2.0][Woodduck][STK]There has no terminal response when execute "setup call ->cancel".

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Sean Lee [:seanlee][:weilonge]]

The previous bug description is pasted at the bottom.
Here is the summary for the current status:
1. Users go to a option for STK_CMD_SET_UP_CALL.
2. When the call screen is shown, there is a TR 0x10 (STK_RESULT_UICC_SESSION_TERM_BY_USER) sent.
3. The TR(0x10) should not be sent.


We found function stkResTerminate (system/js/icc.js) sends STK_RESULT_UICC_SESSION_TERM_BY_USER when event "visibilitychange" is triggered.

Comment 1

[Sean Lee [:seanlee][:weilonge]]

Attachment: Pull Request

Hello Fernando, Arthur,

Here is my PR for this bug. Please help to review it. Thank you.

1. Clear the event of onVisibilityChange when any option is clicked.
2. Redirect visibilityChange of Settings to System app. System app handles the event is a better strategy.
3. Add test case to handle on visibility change event from Settings app.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8525967 [details] [review]
Pull Request

The direction looks good to me. I left some comments in github regarding the naming. Please check, thanks!

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Hi Arthur,
The patch is updated. Please help to see the changes. Thank you.

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8525967 [details] [review]
Pull Request

LGTM.
Asking Manuel for testing in a real device

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8525967 [details] [review]
Pull Request

Looks good, thanks!

Comment 7

[Sean Lee [:seanlee][:weilonge]]

Hello Arthur,  Fernando,

Thank you!!


gaia-try PASS: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=4e3698d1d1b2

landed on https://github.com/mozilla-b2g/gaia/commit/80bc1445959db79e9d2e947cc56e1eb7b0d3d0f0

Comment 8

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8525967 [details] [review]
Pull Request

Works fine on device!

Thanks for the patch

Comment 9

[Kai-Zhen Li [:seinlin][:kli]]

Per comment 7.

Comment 10

[Kai-Zhen Li [:seinlin][:kli]]

Uplift to 2.0m get conflicts in apps/system/js/icc.js.

Comment 11

[Sean Lee [:seanlee][:weilonge]]

Attachment: Pull Request for v2.0m

Comment 12

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/6d0819237dedee9d2092a8a117b7ad590f4bcd1b

Comment 14

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8525967 [details] [review]
Pull Request

This patch can provide better STK user experience in FxOS.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):

[User impact] if declined:
STK feature will be abnormal if the visibility behavior is not fixed.

[Testing completed]:
1. Implement Unit Test and test PASS.
2. Partner tested PASS in their LAB. (see bug 1093993)

[Risk to taking this patch] (and alternatives if risky):

[String changes made]:

Comment 15

[GitHub Autolander Bot]

Attachment: [PullReq] weilonge:seanlee/STK/v2.1/Bug1102185 to mozilla-b2g:v2.1

Comment 16

[Sean Lee [:seanlee][:weilonge]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/dd28f69928cd832be352b6c3ea300993a9c0a845