1102237 - Share context menu freezes in animation when "Add to Firefox" is chosen on Android 5.0

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Nexus 5 (Android 5.0)
Build: Firefox for Android 36.0a1 (2014-11-19)

Steps to reproduce:
1. Open about:home
2. Long tap on a page from Top Sites grid view and choose Share
3. From the "Share via" menu choose "Add to Nightly" option

Expected results:
- The dialog closes as soon as the option is chosen

Actual result:
- After the option is chosen, the dialog becomes transparent and only after that closes

Note:
-See the following video: 
https://www.youtube.com/watch?v=ikfUlXuze3A&feature=youtu.be
- I cannot reproduce on other devices

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Good eye!

I can repro on my 5.0 N4.

It looks like Android moves the context menu into the background until it hits the active Activity (like a card stack) and then pushes them into the background together. Then, for full screen Activities, Android slides the new Activity to the top of the stack, again, like a stack of cards.

Our share overlay breaks this paradigm by removing the animation ([1]? or because we're not fullscreen?) where the underlying Activity drops out and instead stops the animation in the middle (which is why the context menu appears to freeze). It also doesn't have the same visual depth when the share overlay slides in.

Options:
  * Attempt to override the context menu to animate out differently
  * Replace the context menu with a custom menu that we can change the animations however we want
  * Change the share overlay animation to better fit within the context of Android L (i.e. physical metaphors - the slide in is a bit too smoothly artifical)

Anthony, any thoughts?

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/overlays/ui/ShareDialog.java?rev=64b25e313439#119

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Michael Comella (:mcomella) from comment #1)
>   * Change the share overlay animation to better fit within the context of
> Android L (i.e. physical metaphors - the slide in is a bit too smoothly
> artifical)

I think we should definitely try to use L's animation API/interaction library where possible (for users on Android 5.0). This is something I've brought up to liuche as well in our Shadow efforts - Z property! (bug 1137921)

+1 for this. Let me know what you need from me

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We can override the Activity enter and exit animations, e.g.:

https://developer.android.com/reference/android/R.attr.html#activityCloseEnterAnimation

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.