1130188 - (share-overlay-v2) [meta] Implement v2 design for Share Overlay

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Overlays, enhancement)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Latest mock is bug 1059554 comment 13, though after talking with :antlam, we don't want to cover the toolbar in other apps.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1130188/mcomella

/r/3433 - Bug 1130188 - Clean up OverlayDialogButton's initialization. r=mhaigh
/r/3435 - Bug 1130188 - Remove header container in share overlay & roughly style text. r=mhaigh

Pull down these commits:

hg pull review -r e933808266c1130b23703cba98095df6e2113bd2

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

What's the priority on the v2 work? I know we are working on:
1. Improving "Send to Devices" from inside the application
2. Adding support for "Open in Background"

I don't think we need to fast track the Share Overlay work though. We have other things to get done first. Any reason to bump the priority?

Comment 3

[Richard Newman [:rnewman]]

Looking from outside, I'd just observe that there's some polish and L-related work that never got done once ckitching left. Even polish becomes high priority once left long enough.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> What's the priority on the v2 work? I know we are working on:
> 1. Improving "Send to Devices" from inside the application
> 2. Adding support for "Open in Background"
> 
> I don't think we need to fast track the Share Overlay work though. We have
> other things to get done first. Any reason to bump the priority?

Anthony recommended that I work on this bug and (1) (bug 1122302), which I interpreted to have equal priority. I can see why it's more important for (1) to be improved so I'll prioritize that over this, but I agree with Richard in comment 3 that polish is important too, so I'm going to get back to this right after.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.