1102355 - Contacts buttons are misaligned in RTL

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect, P3)

Description

[Doug Sherk (:drs) (inactive)]

Attachment: Screenshot

The buttons to call and SMS contacts are misaligned. This is likely due to the use of `float` instead of flexbox.

This code is also used in the Dialer, but I think that it's better for the Contacts team to deal with this as it was originally refactored from the Contacts app.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 26452

Hi folks,

this patch is the easy solution, didn't refactor the current code to use flexbox, we don't use it on the contact details so far.

But if you don't like it lets refactor to use it

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: 2014-11-23-19-07-13.png

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: 2014-11-23-19-07-26.png

Comment 5

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8528457 [details] [review]
Pointer to PR 26452

I think that this fix could use some more work to be more in line with how we're fixing things in other areas. My understanding is that, in general, using `html[dir="rtl"]` should be considered a last resort.

One other thing that I noticed is that the call icon looks a bit misplaced. I'll attach a screenshot of what I mean after this.

Comment 6

[Doug Sherk (:drs) (inactive)]

Attachment: Screenshot of call icon misplacement and phone number centering

This is the screenshot that I referred to in comment 5.

Ahmed, what would you expect to see here? I'm actually not sure because we haven't been told what to do with the SIM indicator.

We can file followups for this once we have a better idea of what to do.

Comment 7

[Fang Shih [:fang]]

Comment on attachment 8528460 [details]
2014-11-23-19-07-13.png

Looks good to me! Only the phone number and the email address text need to move right aligned with the section title. It shouldn't have empty space on the right side, Thanks!

Comment 8

[Fang Shih [:fang]]

Comment on attachment 8528461 [details]
2014-11-23-19-07-26.png

This one has the same issue. The email address and the phone number are not aligned with the section title. It should be right aligned like "Contact details" text. Thanks!

Comment 9

[Fang Shih [:fang]]

Attachment: RTL_contactbug.jpg

Attached the correct alignment mockup for your reference. Let me know if you any other details. Thanks! : )

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #6)
> Created attachment 8528807 [details]
> Screenshot of call icon misplacement and phone number centering
> 
> This is the screenshot that I referred to in comment 5.
> 
> Ahmed, what would you expect to see here? I'm actually not sure because we
> haven't been told what to do with the SIM indicator.
> 
> We can file followups for this once we have a better idea of what to do.

Thanks Doug for the feedback and pointing that, will take a look following your advice.

Comment 11

[Dylan Oliver [:doliver]]

RTL triage: P3 -- this bug is not prioritized for inclusion in the 2.2 release.

Comment 12

[Lancy(Leave from Mozilla)]

Attachment: FlameKK_v2.5.png

This issue cannot be reproduced on latest FlameKK v2.2&v2.5 build.
STR:
Precondition: Two active SIM cards are inserted in DUT.
1.Launch Contacts and new a contact with a phone number.
2.Tap the created contact to view the details.
**Call bar should be right-aligned. SIM selection text should be displayed at left side of phone icon and left-aligned in call bar, and the phone icon is not mirrored.

See attachment: FlameKK_v2.5.png
Reproducing rate:0/10

If anyone can repro it, please reopen again.

Device: Flame KK v2.2:
Build ID               20150805032505
Gaia Revision          f8b119ac30e97df991c97682ac4d4f9ca22e1793
Gaia Date              2015-07-31 13:20:55
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0c7a85251e10
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150805.065842
Firmware Date          Wed Aug  5 06:58:54 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.5
Build ID               20150805030212
Gaia Revision          c5425d9f1f5184731a59ed4bc99295acbde30390
Gaia Date              2015-08-04 16:09:19
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f3b757156f69
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150805.063609
Firmware Date          Wed Aug  5 06:36:20 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0