1102437 - Logged in users should not receive notifications from Rooms created by Guest and vice versa

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Maire Reavy [:mreavy]]

As a logged in user, I want to receive notifications from Rooms I created while I was logged in -- not notifications created by Guest

Similiarly, Guest should not receive notifications for logged in users.  Guest should receive notifications created by Guest.

Comment 1

[Maire Reavy [:mreavy]]

[Tracking Requested - why for this release]:
We need this fix for "Rooms", which is already enabled in Fx35.

Comment 2

[:shell escalante]

hi mike - are you going to be able to finish off this week?  otherwise Maire will find someone to assign.

Comment 3

[Marco Mucci [:MarcoM]]

Added to IT 37.1

Comment 4

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: make sure only push updates for the appropriate channel are processed

Comment 5

[Mike de Boer [:mikedeboer]]

Pushed to fx-team as https://hg.mozilla.org/integration/fx-team/rev/13e45db8c453

Thanks!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/13e45db8c453

Comment 7

[Paul Silaghi, QA [:pauly]]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #0)
> As a logged in user, I want to receive notifications from Rooms I created
> while I was logged in -- not notifications created by Guest
The icon no longer gets blue, but I still hear the sound notification when the guest joins the call.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8533648 [details] [diff] [review]
Patch v1: make sure only push updates for the appropriate channel are processed

Approval Request Comment
[Feature/regressing bug #]: Rooms

[User impact if declined]: confusing overlap between Guest and FxA-signed-in modes - you see updates for the Guest if you're signed in, or for FxA if logged out.

[Describe test coverage new/current, TBPL]: On m-c for days; Tests updated to cover this case.

[Risks and why]: Actual patch is tiny; couple of lines; 90% of the patchfile is updates to the tests.  Low risk.


[String/UUID change made/needed]: none

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/07b7814d5c17

Comment 10

[Paul Silaghi, QA [:pauly]]

(In reply to Paul Silaghi, QA [:pauly] from comment #7)
> (In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #0)
> > As a logged in user, I want to receive notifications from Rooms I created
> > while I was logged in -- not notifications created by Guest
> The icon no longer gets blue, but I still hear the sound notification when
> the guest joins the call.
I'm not sure this is fixed. Maire?

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

I've tested some variations (on Aurora), and all seem to work.  There may be some bugs (perhaps fixed in a later bug) where some updates are missed when you log out and log back in, but I definitely didn't see any updates I shouldn't get.  This may be a server issue

Comment 12

[Maire Reavy [:mreavy]]

(In reply to Randell Jesup [:jesup] from comment #11)
> I've tested some variations (on Aurora), and all seem to work.  There may be
> some bugs (perhaps fixed in a later bug) where some updates are missed when
> you log out and log back in, but I definitely didn't see any updates I
> shouldn't get.  This may be a server issue

Yes, I believe this bug is fixed based on my testing.  

Randell -- can you open a bug (or bugs) for any missed updates?  I would file this new bug (or bugs) under Loop::Server.  Thanks.

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d2adf4c354f0

Comment 14

[Paul Silaghi, QA [:pauly]]

Forget about comment 10, everything works fine.
Verified fixed FF 35b5, 36.0a2 (2014-12-19), 37.0a1 (2014-12-19) Win 7.

Comment 15

[Paul Silaghi, QA [:pauly]]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #0)
> As a logged in user, I want to receive notifications from Rooms I created
> while I was logged in
As a note here, you won't receive any notification if you're logged in and share the URL with a guest.

Comment 16

[Mark Banner (:standard8)]

Clearing NI - it appears that the issue is fixed as per comment 14, no follow-up bugs required.