1113723 - Sometimes no sound when another participant joins a user's room

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Maire Reavy [:mreavy]]

We're hearing reports that if a user is not in the room and someone joins, the system notification shows up and the icon gets blue, but there is no sound.

This bug is about investigating why there is no sound in certain cases and fixing it.

Comment 1

[Maire Reavy [:mreavy]]

A few folks have been caught by surprise to see someone waiting in their room because they expected to hear a sound.  The system notification show up and icon gets blue, but they aren't hearing a sound.

Comment 2

[Mike de Boer [:mikedeboer]]

Well, this is expected behavior due to http://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser-loop.js#238

We left out playing a sound separately, because the notifications play their own default sounds. However, that might not be the case on all platforms, so the best we can do here is play the sound on all platforms _except_ OSX.

How does that sound? (no pun intended ;) )

Comment 3

[Maire Reavy [:mreavy]]

Definitely, all platforms except OSX are better than nothing.  Is there anything we can do/play for OSX?   (Even an ugly hack.)

Comment 5

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: play a sound when someone joins a room

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/fx-team/rev/3d3e53c0b21a

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8540763 [details] [diff] [review]
Patch v1: play a sound when someone joins a room

Approval Request Comment
[Feature/regressing bug #]: Rooms

[User impact if declined]: Inconsistent playing of sounds when users enter the room

[Describe test coverage new/current, TBPL]: on mc shortly.  Automated tests aren't reasonable for this.  Will manually test.

[Risks and why]: Very low risk change; virtually a 1-liner

[String/UUID change made/needed]: none

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3d3e53c0b21a

Comment 9

[Marco Mucci [:MarcoM]]

Added to IT 37.3

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d21cf86760b0

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/5aa2a3e4341e

Comment 12

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 35 RC, 36.0a2 (2015-01-06), 37.0a1 (2015-01-06) Win 7.