1102491 - SIM picker default parenthesis are misplaced

Status: RESOLVED DUPLICATE of bug 1082541

(Firefox OS Graveyard :: Gaia, defect)

Description

[Doug Sherk (:drs) (inactive)]

Attachment: Screenshot

The "(default)" indicator on the SIM picker is misplaced in RTL mode.

Comment 1

[Doug Sherk (:drs) (inactive)]

Ahmed, as you can see from the screenshot, there are other issues as well. It's not clear to me whether or not these problems are within the scope of bug 1082541. Should I file bugs for the other problems as well?

Comment 2

[Ahmed Nefzaoui [:Nefzaoui]]

The only bug here is the text alignment, the parenthesis being messed up like that is just a matter of lack of localization. As soon as these string are localized to Arabic it will show up correctly.
But can you please try inspecting the app and changing that string with
الشريحة 1 (الإفتراضية)
So w can see if the problem persists? :)

Comment 3

[Doug Sherk (:drs) (inactive)]

This is actually not just one string. The "SIM x" part is one string, and the "(default)" part is another, with some padding to separate them. The "(default)" part is selectively set to `display: none` or `display: initial` depending on whether or not we have a default SIM.

Since each of them are spans, I think that this might still work. Could you advise how I should insert the strings into each of these spans?

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

So SIM x should be
الشريحة 1
I'm using 1 instead of x because the character x might make the string a little messy then :)

And (default) should be
(الإفتراضية)

Comment 5

[Doug Sherk (:drs) (inactive)]

Thanks, that looks correct, but the whole string is left-aligned still. I assume that'll be fixed when bug 1082541 and its dependencies are resolved?

Comment 6

[Ahmed Nefzaoui [:Nefzaoui]]

If they're within a gaia-element then yes.. Even though I'm kind of lost why those gaia-elements are being used now since AFAIK the only gaia-element scheduled for 2.2 is gaia-header..

Comment 7

[Doug Sherk (:drs) (inactive)]

(In reply to Ahmed Nefzaoui [:Nefzaoui] (Please needinfo? | Away from 30 OCT to 18 NOV) from comment #6)
> If they're within a gaia-element then yes.. Even though I'm kind of lost why
> those gaia-elements are being used now since AFAIK the only gaia-element
> scheduled for 2.2 is gaia-header..

We implemented a shared component SIM picker in bug 1037868 and bug 1045820. It was something that we had time to do, so we got to it even though it wasn't on the schedule.

To QA, please verify that this is fixed once bug 1082541 is resolved.

Comment 8

[Peter Bylenga [:PBylenga]]

Mass Edit: adding the [rtl-meta]