Keypad delete button is pointed the wrong way and padded incorrectly

VERIFIED FIXED in 2.2 S1 (5dec)

Status

defect
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: drs, Assigned: drs)

Tracking

unspecified
2.2 S1 (5dec)
Dependency tree / graph
Bug Flags:
in-moztrap +

Firefox Tracking Flags

(b2g-v2.2 verified)

Details

(Whiteboard: [planned-sprint c=1])

Attachments

(4 attachments)

Assignee

Description

5 years ago
Posted image Screenshot
In RTL mode, the keypad delete button is too far to the left, and is pointing the wrong way.
Assignee

Comment 1

5 years ago
Ahmed, here is my proposal for how this will look after being fixed. Does this look correct to you, other than minor imperfections in pixels of padding?
Flags: needinfo?(nefzaoui.ahmed)
Well, I think the best way to do this is what's proposed in Bug 1011731, Forcing the whole Dialer keypad view to be rendered LTR even with RTL languages. That is because the direction people write numbers with in RTL languages is the same of non-RTLs (i.e English, French...), all from left towards right.
Competitors does that too :) Which actually makes sense.. :)
Flags: needinfo?(nefzaoui.ahmed)
Assignee

Updated

5 years ago
Target Milestone: --- → 2.2 S1 (5dec)
Assignee

Comment 3

5 years ago
This might end up not being any work based on comment 2, but I need to talk with Stephany about this.
Assignee: nobody → drs.bugzilla
Whiteboard: [planned-sprint c=?] → [planned-sprint c=1]
Assignee

Updated

5 years ago
See Also: → 1011731
Assignee

Comment 4

5 years ago
PR: https://github.com/mozilla-b2g/gaia/pull/26565

Needinfo on myself for rebase and demo.
Flags: needinfo?(drs.bugzilla)
Attachment #8530465 - Flags: review?(gsvelto)
Assignee

Comment 5

5 years ago
Bug 1011731 partially fixed this, but not entirely.
Status: NEW → ASSIGNED
Depends on: 1011731
Comment on attachment 8530465 [details] [diff] [review]
Force render the keypad delete button in LTR, even in RTL mode.

Good to see that this one ended up being a one-liner :)
Attachment #8530465 - Flags: review?(gsvelto) → review+
Assignee

Comment 7

5 years ago
Master: https://github.com/mozilla-b2g/gaia/commit/65e97a2624638c726cce27f0b7af81952a5f312b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: needinfo?(drs.bugzilla)
Resolution: --- → FIXED

Updated

5 years ago
Keywords: verifyme

Comment 8

5 years ago
Accordding to  Comment 2 
Forcing the whole Dialer keypad view to be rendered LTR even with RTL languages
This issue verified successfully on Flame 2.2
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8067c111ddff
Build-ID        20150118002501
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
Refer to video
Status: RESOLVED → VERIFIED
Keywords: verifyme

Comment 9

5 years ago
Posted video VIDEO0255.mp4
Flags: in-moztrap+
You need to log in before you can comment on or make changes to this bug.