110290 - History folders empty

Status: VERIFIED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Tracy Walker [:tracy]]

seen on commercial builds:

windows 2001-11-15-05-trunk
linux 2001-11-15-06-trunk
mac 2001-11-15-04-trunk

- Browse a few pages

- Go to Tasks | Tools | History

- Click on the folder marked Today

Expected Results:  The folder should contain the history of today's browsing
tested results: the folder is empty

Comment 1

[Campanella]

I find that this problem occurs History Sidebar on mac 2001-11-15-08-trunk. 
When I quit mozilla and open history.dat(by text-editor), history.dat is not empty.

Comment 2

[Sébastien Delahaye]

This cause the URI bar to always propose the 'Search Google for "your URI"'
sentence instead of completing the URI from the History.

It didn't occur on build 2001111403 (but occurs on build 2001111503).

Comment 3

[Kathleen :Brade]

-->alecf; he'll investigate

Comment 4

[Alec Flett]

Attachment: also acknowledge empty cells as non-existant

I'm not sure why this worked for me yesterday - maybe cells are being lazily
created? Anyway, this should cover all cases.

Comment 5

[Alec Flett]

and it's in!

Comment 6

[lpham]

Mac respin completed.  Please verify it.
ftp://sweetlou/products/client/seamonkey/macos/8.x/ppc/2001-11-15-14-trunk
ftp://sweetlou/products/client/seamonkey/macos/8.x/ppc/2001-11-15-14-trunk
Loan

Comment 7

[Suresh]

Works fine in the mac respin builds. I'll leave it to claudius to Verify it on 
all platforms and mark this bug verified :)

Comment 8

[Claudius Gayle]

VERIFIED Fixed with 200111514 MacOS 8.x build
VERIFIED Fixed with 200111513 RHLinux build
still waiting on a Win build with the fix

Comment 9

[R.K.Aa.]

*** Bug 110513 has been marked as a duplicate of this bug. ***

Comment 10

[Tracy Walker [:tracy]]

verified on commercial builds:

windows 2001-11-16-05-trunk
linux 2001-11-16-06-trunk
mac 2001-11-16-04-trunk
mac osx 2001-11-16-16-08-trunk

Comment 11

[Jaime Rodriguez, Jr.]

who can sr and r= this one. i realize it is already in the trunk, but we'd like
a review before landing it on the 6.2.1, and 094 branch.

Comment 12

[Jaime Rodriguez, Jr.]

adding rpotts and radha to see if they can help with the s/sr.

Comment 13

[Jaime Rodriguez, Jr.]

waterson - can you pls sr= this bad boy. we'd like to take this on the 6.2
branch as soon as we have your blessing.

Comment 14

[Chris Waterson]

sr=waterson

Comment 15

[Radha on family leave (not reading bugmail)]

After taking a second look at the patch, I see that it is quite harmless. The
patch has fixed the problem in the trunk too. r=radha

Comment 16

[Jaime Rodriguez, Jr.]

Radha - Could you pls check this one into the 6.2 branch, too?

Comment 17

[Jaime Rodriguez, Jr.]

PDT+, we need to get this one on the 6.2 branch.

Comment 18

[Claudius Gayle]

Whoa!
Why would this need to go into the 6.2 branch? Why would we think it exists in
the 6.2 branch?
This bug was introduced as a regression on the trunk on or around 2001-11-15. It
is a smoketest blocker. There is no chance on Earth this bug would exist in the
branch as that would either indicate we shipped 6.2 with it or someone checked
in to that branch and trunk causing the regression. I can verify that neither
was the case.

Just to be sure I looked at a 2001-11-19-22 6.2 branch build and it of course
does not exist.

Am I totally off base? Am I missing something?

Comment 19

[Jaime Rodriguez, Jr.]

If I understand this right,  Bug 102043 introduced this issue into the trunk,
and alecf belives checking resolving this bug on the branch will enable the
patch for Bug 102043 to funtion proberly.

Comment 20

[Claudius Gayle]

Oh heheh, this is THAT bug, my bad. I read the other before but never matched
the numbers up in my head. Ok, sorry to raise alarm, it just didn't seem right
to be checking extra stuff in to such a tightly controlled branch release.

Comment 21

[rpotts (gone)]

Comment on attachment 57932 [details] [diff] [review]
also acknowledge empty cells as non-existant

sr=[e-mail]

works for me :-)

Comment 22

[Marek Z. Jeziorek]

rpotts/alecf/anybody,  do we need any additional work for this on the 0.9.4
branch for embeding customers?

Comment 23

[Marcia Knous [:marcia]]

EDT - removing edt keyword.