1102911 - The search engine favicons are distorted in search preferences on Linux

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Attachment: search_distorted_icons.png

Reproducible with Firefox 34 Beta 11 - BuildID: 20141120192249

Environment: Windows 7 x64, Windows 8 x86, Ubuntu 12.04 x86, Mac OS X 10.9.5

Steps to reproduce:
1. Open Firefox and go to Preferences -> Search.
2. See how the search engine favicons display in the list from the bottom.

Expected results:
Favicons display same as in the drop-down selector (16x16).

Actual results:
Favicons display distorted (16x14).

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Florian: if this is a quick fix (Linux only?), then let's get this in too.

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

As this distorts our partner logos (albeit not in primary UI), I would also like to get this fix in if possible. Can this be fixed today?

Comment 3

[Florian Quèze [:florian]]

Attachment: Fix

This bug is Linux-only.

The bug is caused by the .checkbox-label-box anonymous element of the checkbox having 2px transparent borders that are caused by |-moz-appearance: checkbox-label;|, which is only set on Linux (http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/linux/global/checkbox.css#40).

Comment 4

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8527833 [details] [diff] [review]
Fix

Beta+

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ad1b0b9af31e
https://hg.mozilla.org/releases/mozilla-release/rev/ad1b0b9af31e

Comment 6

[Petruta Horea [:phorea], Desktop QA]

Attachment: distortedWin.png Windows

Verified using Firefox 34.0 RC build (20141124205320) under Win 7 64-bit, Ubuntu 14.04 32-bit and Mac OSX 10.9.5.

The issue is fixed only under Ubuntu, it is still reproduced for Windows builds, see attachment.

Comment 7

[Florian Quèze [:florian]]

(In reply to Petruta Rasa [QA] [:petruta] from comment #6)
> Created attachment 8528383 [details]
> distortedWin.png Windows
> 
> Verified using Firefox 34.0 RC build (20141124205320) under Win 7 64-bit,
> Ubuntu 14.04 32-bit and Mac OSX 10.9.5.
> 
> The issue is fixed only under Ubuntu, it is still reproduced for Windows
> builds, see attachment.

Moving this to bug 1104846.

Comment 8

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Marking as Verified since remaining Windows issue was moved to a separate bug, and this was already verified as fixed for Mac and Linux.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8527833 [details] [diff] [review]
Fix

Approving for Aurora since this has already landed on Beta, and it's a holiday so this is the last aurora approval round before the weekend.

Comment 10

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/0447336d18b2

Comment 11

[Marco Mucci [:MarcoM]]

Hi Florian, can you provide a point value.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0447336d18b2

Comment 13

[Florian Quèze [:florian]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/43436dac11ef

Comment 14

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed under Ubuntu 14.04 LTS 64-bit with Firefox 35 beta 1, Developer Edition 36.0a2 2014-12-02.
The issue is not present in Nightly 37.0a1 so I changed the status to unaffected.