Closed Bug 1104846 Opened 9 years ago Closed 9 years ago

The search engine favicons are distorted in search preferences on Windows

Categories

(Firefox :: Search, defect)

34 Branch
All
Windows 7
defect
Not set
normal
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 36
Iteration:
37.1
Tracking Status
firefox33 --- unaffected
firefox34 + verified
firefox35 + verified
firefox36 + verified

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

I fixed the Linux case in bug 1102911, but bug 1102911 comment 6 points out that it still exists on Windows.

+++ This bug was initially created as a clone of Bug #1102911 +++

Reproducible with Firefox 34 Beta 11 - BuildID: 20141120192249

Environment: Windows 7 x64, Windows 8 x86, Ubuntu 12.04 x86, Mac OS X 10.9.5

Steps to reproduce:
1. Open Firefox and go to Preferences -> Search.
2. See how the search engine favicons display in the list from the bottom.

Expected results:
Favicons display same as in the drop-down selector (16x16).

Actual results:
Favicons display distorted (16x14).
Summary: The search engine favicons are distorted in search preferences on Linux → The search engine favicons are distorted in search preferences on Windows
Attached patch FixSplinter Review
The Windows CSS has a 1px transparent border.
Assignee: nobody → florian
Attachment #8528454 - Flags: review?(felipc)
Comment on attachment 8528454 [details] [diff] [review]
Fix

Why are you putting this in a content stylesheet rather than themes?
(In reply to Dão Gottwald [:dao] from comment #2)
> Comment on attachment 8528454 [details] [diff] [review]
> Fix
> 
> Why are you putting this in a content stylesheet rather than themes?

Because this was initially developed as an add-on, and having only one CSS file rather than one for content + one per platform was significantly easier to maintain.

It's one of the things I intend to cleanup when/before landing this new code on central. For the beta patch, I prefer keeping the changes to the strict minimum.
Comment on attachment 8528454 [details] [diff] [review]
Fix

r+ with the expectation that we will clean up this shortly after the time pressure for beta winds down
Attachment #8528454 - Flags: review?(felipc) → review+
Attachment #8528454 - Flags: approval-mozilla-release?
Attachment #8528454 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Comment on attachment 8528454 [details] [diff] [review]
Fix

Reviewed with Florian. Release+ Beta+
Attachment #8528454 - Flags: approval-mozilla-release?
Attachment #8528454 - Flags: approval-mozilla-release+
Attachment #8528454 - Flags: approval-mozilla-beta?
Attachment #8528454 - Flags: approval-mozilla-beta+
Verified as fixed using Firefox 34.0 build 2 (20141125180439) under Win 7 and Win 8.1 64-bit.
Hi Florian, can you provide a point value.
Status: NEW → ASSIGNED
Iteration: --- → 37.1
Flags: needinfo?(florian)
Flags: firefox-backlog?
Flags: firefox-backlog+
Points: --- → 1
Flags: needinfo?(florian)
https://hg.mozilla.org/mozilla-central/rev/7fe723e2de8b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Verified as fixed using Firefox 35 beta 1 (20141201162954) and Firefox Developer Edition 36.0a2 20141202004003
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.