1102959 - Should check battery before downloading update only for FOTA (recovery) updates

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

STR:
- Have a low battery percentage < 25%
- Download an OTA update and try to install it.
- Be informed that you can't install the update.

This is problematic for a few reasons. If you restart your device, it will tell you that it can't find an update until the next OTA is published (perhaps this is another bug). Additionally the update is missing, meaning you have to download it again.

If we are going to prompt about battery, I think we should also do so *before* the download as well, especially if we have such a poor experience once we have the update downloaded.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

related to bug 959195?  We also have bug 1039480 which was marked a dup of bug 1034735

Also see bug 946550 / bug 930124

Comment 2

[Kevin Grandon :kgrandon]

Thanks Naoki. This bug is definitely related to all of those. If bug 946550 / bug 930124 is solved, then we may not need this. For now I think we should probably check the battery level before starting the download as well. To me it doesn't seem nice to download the update then not be able to apply it.

Comment 3

[:gerard-majax]

(In reply to Kevin Grandon :kgrandon from comment #0)
> STR:
> - Have a low battery percentage < 25%
> - Download an OTA update and try to install it.
> - Be informed that you can't install the update.
> 
> This is problematic for a few reasons. If you restart your device, it will
> tell you that it can't find an update until the next OTA is published
> (perhaps this is another bug). Additionally the update is missing, meaning
> you have to download it again.
> 
> If we are going to prompt about battery, I think we should also do so
> *before* the download as well, especially if we have such a poor experience
> once we have the update downloaded.

I think we should rather fix the fact that after reboot I cannot install the downloaded update.

Comment 4

[:gerard-majax]

Kevin, I'll check if fixing bug 946550 is quick. According to your comment 2, we may not need to do anything in the current bug if this one is fixed :)

Comment 5

[Kevin Grandon :kgrandon]

Thanks for the update here Alex! Even if bug 946550 is fixed, I'm still not sure it should let you download an update if you can't install it, I think it should at least warn you. I guess that's a question for UX though.

Comment 6

[:gerard-majax]

Downloading an OTA package, with battery > 25%, I'm prompted to install or not. If I tap "Later", it's properly applied on the next reboot.

Comment 7

[:gerard-majax]

(In reply to Kevin Grandon :kgrandon from comment #0)
> STR:
> - Have a low battery percentage < 25%
> - Download an OTA update and try to install it.
> - Be informed that you can't install the update.
> 
> This is problematic for a few reasons. If you restart your device, it will
> tell you that it can't find an update until the next OTA is published
> (perhaps this is another bug). Additionally the update is missing, meaning
> you have to download it again.
> 
> If we are going to prompt about battery, I think we should also do so
> *before* the download as well, especially if we have such a poor experience
> once we have the update downloaded.

As far as I could test, we are indeed properly applying the OTA after reboot, even when I faked a low battery level (and I got the dialog).

The original bug for this feature was bug 959195 and it was mostly intended for FOTA (applied in recovery) and not OTA.

Maybe we should just not perform this check for OTA packages?

Comment 8

[Kevin Grandon :kgrandon]

(In reply to Alexandre LISSY :gerard-majax from comment #7)
> Maybe we should just not perform this check for OTA packages?

I think that is a possible solution for OTA updates.

I still think there's a bug here for FOTA updates, but haven't tested those. Basically the messaging seemed to me that the download did not work if I did not have sufficient battery.

Comment 9

[:gerard-majax]

(In reply to Kevin Grandon :kgrandon from comment #8)
> (In reply to Alexandre LISSY :gerard-majax from comment #7)
> > Maybe we should just not perform this check for OTA packages?
> 
> I think that is a possible solution for OTA updates.
> 
> I still think there's a bug here for FOTA updates, but haven't tested those.
> Basically the messaging seemed to me that the download did not work if I did
> not have sufficient battery.

No, I don't think there is any issue for FOTA, because in this case, we will have kept in mind that there was an update, and we will directly reapply it. What you reported as a bug in your first comment, "If you restart your device, it will tell you that it can't find an update until the next OTA is published (perhaps this is another bug)." just confirms that you, indeed, got the OTA update applied during the reboot.

Hence, it's normal it will only detect a new update when one is available.

Comment 10

[Kevin Grandon :kgrandon]

Ok, I think I'm clear on the issue then. I'm fine if you want to use this bug to remove the OTA apply check then. Thanks!

Comment 11

[:gerard-majax]

Updating the title, since we want this check to be there because recovery update may consume quite some battery.

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] lissyx:bug1102959 > mozilla-b2g:master

Comment 13

[:gerard-majax]

Green: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=eba5092008c57c1728891950d7b6759b217e7f71

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8590753 [details] [review]
[gaia] lissyx:bug1102959 > mozilla-b2g:master

LGTM, thanks!

Comment 15

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/eced99ac91514cd2499796bfb16765a6e31ccda4