Closed Bug 1103074 Opened 10 years ago Closed 9 years ago

Add configuration for taskcluster phone builds

Categories

(Release Engineering :: Applications: MozharnessCore, defect, P1)

All
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wcosta, Assigned: wcosta)

References

Details

Attachments

(1 file)

      No description provided.
Attachment #8527589 - Flags: review?(jlund)
Comment on attachment 8527589 [details] [diff] [review]
Add taskcluster phone build configuration.

Review of attachment 8527589 [details] [diff] [review]:
-----------------------------------------------------------------

if it works for you, works for me! :)

::: configs/b2g/taskcluster-phone.py
@@ +7,5 @@
> +        'prep-upload'
> +    ],
> +    "upload": {
> +        "default": {
> +            "upload_dep_target_exclusions": []

do we need to include anything in default?

http://mxr.mozilla.org/build/source/ash-mozharness/scripts/b2g_build.py#289 suggests it doesn't even need this item. If you think it's more explicit, leaving this makes sense. :)
Attachment #8527589 - Flags: review?(jlund) → review+
(In reply to Jordan Lund (:jlund) from comment #2)
> Comment on attachment 8527589 [details] [diff] [review]
> Add taskcluster phone build configuration.
> 
> Review of attachment 8527589 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> if it works for you, works for me! :)
> 
> ::: configs/b2g/taskcluster-phone.py
> @@ +7,5 @@
> > +        'prep-upload'
> > +    ],
> > +    "upload": {
> > +        "default": {
> > +            "upload_dep_target_exclusions": []
> 
> do we need to include anything in default?
> 
> http://mxr.mozilla.org/build/source/ash-mozharness/scripts/b2g_build.py#289
> suggests it doesn't even need this item. If you think it's more explicit,
> leaving this makes sense. :)

Yeah, I think it is better :)
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.