1103119 - Search drop down fails to display properly if a search engine has no icon

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch

Comment 2

[Dave Townsend [:mossop]]

https://hg.mozilla.org/releases/mozilla-beta/rev/30ca4c851a16

[Tracking Requested - why for this release]:

This was causing some issues with tests I was writing after bug 1088660 landed.

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8526953 [details] [diff] [review]
patch

Review of attachment 8526953 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/urlbarBindings.xml
@@ +957,3 @@
>            uri = uri.spec;
> +          this.setAttribute("src", PlacesUtils.getImageURLForResolution(window, uri));
> +        }

You need to handle the "else" case here. Either show a placeholder icon, or just remove the "src" attribute.

Your patch currently shows the icon of the previously-default provider after the user changed the default provider to a provider without icon.

Currently if you don't set the 'src' attribute, we fallback to the icon specified in some old CSS, which is inconsistent.

On Mac/Linux you'll get: http://mxr.mozilla.org/mozilla-beta/source/toolkit/themes/osx/mozapps/places/defaultFavicon.png
On Windows you'll get the first icon of this image: http://mxr.mozilla.org/mozilla-beta/source/toolkit/themes/windows/global/icons/folder-item.png

Comment 4

[Petruta Horea [:phorea], Desktop QA]

Reproduced in Firefox 34 beta 11. Verified fixed using Firefox 34.0 RC build (20141124205320) under Win 7 64-bit, Ubuntu 14.04 32-bit and Mac OSX 10.9.5.

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8526953 [details] [diff] [review]
patch

This landed on beta with a=gavin.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8526953 [details] [diff] [review]
patch

Approving for Aurora since this has already landed on Beta, and it's a holiday so this is the last aurora approval round before the weekend.

Comment 7

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/fcd31dc5cb15

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fcd31dc5cb15

Comment 9

[Marco Mucci [:MarcoM]]

Hi Dave, can you assign a point value.

Comment 10

[Florian Quèze [:florian]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7f675d2bd889

Comment 11

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 34 Beta 11 (20141120192249) using Windows 7 x64.

Verified fixed on Firefox 35 Beta 1 (20141201162954) and Latest Firefox 36.0a2 (2014-12-02) using Windows 7 x64, Ubuntu 12.04 x32 and Mac OSX 10.9.5.