Closed
Bug 1104221
Opened 9 years ago
Closed 9 years ago
Search drop down shows the icon of the previous default engine if the new default doesn't have an icon
Categories
(Firefox :: Search, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox33 | --- | unaffected |
firefox34 | + | verified |
firefox35 | + | verified |
firefox36 | + | verified |
firefox37 | + | unaffected |
firefox-esr31 | --- | unaffected |
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(1 file)
1.54 KB,
patch
|
Felipe
:
review+
lsblakk
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
[Tracking Requested - why for this release]: The fix from bug 1103119 missed an edge case, as I pointed out in bug 1103119 comment 3: > Comment on attachment 8526953 [details] [diff] [review] > patch > > Review of attachment 8526953 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: browser/base/content/urlbarBindings.xml > @@ +957,3 @@ > > uri = uri.spec; > > + this.setAttribute("src", PlacesUtils.getImageURLForResolution(window, uri)); > > + } > > You need to handle the "else" case here. Either show a placeholder icon, or > just remove the "src" attribute. > > Your patch currently shows the icon of the previously-default provider after > the user changed the default provider to a provider without icon. > > Currently if you don't set the 'src' attribute, we fallback to the icon > specified in some old CSS, which is inconsistent. > > On Mac/Linux you'll get: > http://mxr.mozilla.org/mozilla-beta/source/toolkit/themes/osx/mozapps/places/ > defaultFavicon.png > On Windows you'll get the first icon of this image: > http://mxr.mozilla.org/mozilla-beta/source/toolkit/themes/windows/global/ > icons/folder-item.png
Updated•9 years ago
|
status-firefox33:
--- → unaffected
status-firefox35:
--- → affected
status-firefox36:
--- → affected
status-firefox37:
--- → affected
status-firefox-esr31:
--- → unaffected
tracking-firefox35:
--- → +
tracking-firefox36:
--- → +
tracking-firefox37:
--- → +
Assignee | ||
Comment 1•9 years ago
|
||
I was tempted to also change the placeholders, but having 2 glass icons in the same searchbox would look odd on the new UI, so I decided to keep the patch very low risk and only change what I really wanted to get fixed for 34.
Attachment #8527855 -
Flags: review?(felipc)
Attachment #8527855 -
Flags: approval-mozilla-beta?
Updated•9 years ago
|
Attachment #8527855 -
Flags: review?(felipc) → review+
Comment 2•9 years ago
|
||
Comment on attachment 8527855 [details] [diff] [review] Fix Beta+
Attachment #8527855 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 3•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/7b937b21452d https://hg.mozilla.org/releases/mozilla-release/rev/7b937b21452d
Updated•9 years ago
|
QA Contact: petruta.rasa
Comment 4•9 years ago
|
||
Verified as fixed using Firefox 34.0 RC build (20141124205320) under Win 7 64-bit, Ubuntu 14.04 32-bit and Mac OSX 10.9.5.
Assignee | ||
Updated•9 years ago
|
Attachment #8527855 -
Flags: approval-mozilla-aurora?
Comment 5•9 years ago
|
||
Comment on attachment 8527855 [details] [diff] [review] Fix Approving for Aurora since this has already landed on Beta, and it's a holiday so this is the last aurora approval round before the weekend (and merge-day).
Attachment #8527855 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e597f8f270c6
Whiteboard: [fixed-in-fx-team]
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e597f8f270c6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Comment 8•9 years ago
|
||
Hi Florian, can you assign a point value.
Iteration: --- → 37.1
Flags: qe-verify?
Flags: needinfo?(florian)
Flags: firefox-backlog+
Assignee | ||
Updated•9 years ago
|
Points: --- → 1
Flags: needinfo?(florian)
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/9664ebc4bf26
Comment 10•9 years ago
|
||
I was able to reproduce this issue on Firefox 34 Beta 11 (20141120192249) using Windows 7 x64. Verified fixed on Firefox 35 Beta 1 (20141201162954) and Latest Firefox 36.0a2 (2014-12-02) using Windows 7 x64, Ubuntu 12.04 x32 and Mac OSX 10.9.5.
Updated•9 years ago
|
Flags: qe-verify? → qe-verify+
Comment 11•9 years ago
|
||
I was unable to reproduce this issue on Latest Firefox 37.0a1 (2014-12-02) using Windows 7 x64, Ubuntu 12.04 x32 and Mac OSX 10.9.5.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•