1103181 - Remove String.prototype.quote

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Comment 1

[Tom S [:evilpie]]

Attachment: v1 - Remove quote from JS

Comment 2

[Tom S [:evilpie]]

Attachment: v1 - Remove quote from browser

I am basically convinced we can remove this here and now. We have almost no uses in the browser and very low add-on usage. No other browser implements this either.

Comment 3

[Tom S [:evilpie]]

Attachment: v1 - Remove quote from browser

Comment 4

[Tom S [:evilpie]]

Attachment: v2 - Remove quote browser/mobile usage

Comment 5

[Tom S [:evilpie]]

Comment on attachment 8532044 [details] [diff] [review]
v2 - Remove quote browser/mobile usage

I believe pref names are relatively sane, so we don't need to escape anything.

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8532044 [details] [diff] [review]
v2 - Remove quote browser/mobile usage

Review of attachment 8532044 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/config.js
@@ +86,5 @@
>        return;
>      }
>  
>      // If item already in list, it's being changed, else added
> +    let item = document.querySelector(".pref-item[name=\"" + aPrefName + "\"]");

I'm not particularly happy removing this quoting without figuring out an alternative: finding another escaping method, or mapping keys in a more sophisticated way that doesn't require escaping.

I tested. about:config allows me to create prefs with backslashes and quotes in their names, and there is certainly an extant pattern to have computed pref names like:

  [e-mail]-event-fired

or

  urlclassifier.keyupdatetime.https://sb-ssl.google.com/safebrowsing/getkey?client=navclient-auto-ffox2.0&


In short: this is a change you need to _prove_ is safe, because I see nothing to suggest that it won't break.

Comment 7

[Tom S [:evilpie]]

Okay let's use CSS.escape there as well. I indeed didn't consider this case. I don't consider about:config to be critical anyway.

CSS.escape(' \\"') gives "\ \\\\""

Comment 8

[Tom S [:evilpie]]

Attachment: v3 - Remove quote browser/mobile usage

Comment 9

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7794fca7bda8
https://hg.mozilla.org/integration/mozilla-inbound/rev/3bdce03e9ec0
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=18eb6fd79568

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7794fca7bda8
https://hg.mozilla.org/mozilla-central/rev/3bdce03e9ec0

Comment 11

[Kohei Yoshino]

Added to the compat doc: https://developer.mozilla.org/en-US/Firefox/Releases/37/Site_Compatibility