1103410 - crash in java.lang.RuntimeException: Unhandled error for GeckoRequest FindInPage:Find: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import] JS stack:

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-c18cf218-cb11-4da0-afec-806db2141121.
=============================================================

java.lang.RuntimeException: Unhandled error for GeckoRequest FindInPage:Find: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]
JS stack:
get_finder@chrome://global/content/bindings/browser.xml:360:25
FindHelper._init@chrome://browser/content/FindHelper.js:58:4
FindHelper.doFind@chrome://browser/content/FindHelper.js:104:6
FindHelper._findOpened/<@chrome://browser/content/FindHelper.js:36:6
requestHandler.observe<@resource://gre/modules/Messaging.jsm:147:27
TaskImpl_run@resource://gre/modules/Task.jsm:314:39
TaskImpl@resource://gre/modules/Task.jsm:275:2
createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:13

	at org.mozilla.gecko.util.GeckoRequest.onError(GeckoRequest.java:92)
	at org.mozilla.gecko.GeckoAppShell$3.handleMessage(GeckoAppShell.java:438)
	at org.mozilla.gecko.EventDispatcher.dispatchEvent(EventDispatcher.java:166)
	at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:2265)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:371)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:190)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Mark - You looked at a similar bug, right?

Comment 2

[Mark Capella [:capella]]

Attachment: bug1103410.diff

bug 1089655 ... looks like I mucked up the method signature completely :-/

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8528024 [details] [diff] [review]
bug1103410.diff

Review of attachment 8528024 [details] [diff] [review]:
-----------------------------------------------------------------

Ooh. Good catch. We should fix this.


But we should also try to catch this closer to the error. I think this line right here is throwing:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/FindHelper.js#58

Can we wrap this JS in a try-catch and log something to the console there when this happens? We probably need to do something smarter in FindHelper.js to handle the error.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Do we need to dig in a bit more to see "why" browser.finder is failing?

Comment 5

[Mark Capella [:capella]]

Attachment: bug1103410.diff

New patch as suggested by wesj ... whichs avoids the java crash, and moves the logging closer to the actual point of error, which we see extremely rarely, involving receipt of:

0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]

while trying to load module Finder.jsm
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/browser.xml?rev=8c589a6d637e&mark=360-360#354

I've been doing monkey testing and cannot duplicate this to trap it. It's been suggested that I chat with gabor, who by way of introduction I'll ni? in here.

mfinkle, let me know if you think of another line of attack ?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8539126 [details] [diff] [review]
bug1103410.diff

This looks OK for now. If we continue to see this particular problem, we can work on a different, more specific fix.

Comment 7

[Mark Capella [:capella]]

push to try https://tbpl.mozilla.org/?tree=Try&rev=d464f20bc051

Also, note bug 1113698 comment #2 ... error manifests slightly differently, both involving failures of Gecko/Components, but theoretically could be triggered by matching user case involving a phone device and Find In Page actions.

Comment 8

[Mark Capella [:capella]]

https://hg.mozilla.org/integration/fx-team/rev/0ff1c9cd9d15

Comment 9

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/0ff1c9cd9d15