1103432 - Update search shipped with Instantbird

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[aleth [:aleth]]

See for example Bug 1039003, Bug 633773 - Use Google's HTTPS search by default, Bug 958883 - Use HTTPS for Yahoo searches. Hopefully it's possible to just copy across what Firefox uses these days. Flo should know where all that lives ;)

Comment 1

[Patrick Cloke [:clokep]]

Looks like it's in http://dxr.mozilla.org/comm-central/source/im/locales/en-US/searchplugins should just be a copy & paste job.

Comment 2

[Patrick Cloke [:clokep]]

Well...I think some of these are customized for Instantbird actually (the Amazon one, at least, adds the vendor key or whatever to it).

Comment 3

[aleth [:aleth]]

Now with extra bustage:
Timestamp: 05/09/2015 22:20:34
Error: TypeError: this._defaultEngine is null
Source File: resource://gre/components/nsSearchService.js
Line: 4776

Comment 4

[aleth [:aleth]]

The conversation context menu is broken too.

Comment 5

[Florian Quèze [:florian]]

Attachment: Patch

This ports the Makefile.in/jar.mn changes needed to package the search plugins in the omni.ja file instead of in a searchplugins folder in the application directory.

I also added ddg, and updated the other plugins to have HiDPI icons, https URLs, and rel="searchform" instead of a separate <SearchForm>. I haven't touched/updated the CreativeCommons and Answers.com plugins which no longer exist in Firefox.

Comment 6

[aleth [:aleth]]

Comment on attachment 8728159 [details] [diff] [review]
Patch

Review of attachment 8728159 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!

I assume you decided the sync init warning was not worth caring about?
Error: DEPRECATION WARNING: Search service falling back to synchronous initialization. This is generally the consequence of an add-on using a deprecated search service API.

Comment 7

[Florian Quèze [:florian]]

(In reply to aleth [:aleth] from comment #6)

Thanks for the review!

> I assume you decided the sync init warning was not worth caring about?
> Error: DEPRECATION WARNING: Search service falling back to synchronous
> initialization. This is generally the consequence of an add-on using a
> deprecated search service API.

It's a separate bug (bug 955426) that isn't a blocker.

Comment 8

[Florian Quèze [:florian]]

https://hg.mozilla.org/comm-central/rev/b64643fa52db4b8342fbb57a091b37ae163d2595
Bug 1103432 - Ship updated search plugins in the omni.ja file, r=aleth.