Closed Bug 1103432 Opened 7 years ago Closed 6 years ago

Update search shipped with Instantbird

Categories

(Instantbird :: Conversation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 48

People

(Reporter: aleth, Assigned: florian)

Details

(Whiteboard: [1.6-blocking])

Attachments

(1 file)

See for example Bug 1039003, Bug 633773 - Use Google's HTTPS search by default, Bug 958883 - Use HTTPS for Yahoo searches. Hopefully it's possible to just copy across what Firefox uses these days. Flo should know where all that lives ;)
Looks like it's in http://dxr.mozilla.org/comm-central/source/im/locales/en-US/searchplugins should just be a copy & paste job.
Well...I think some of these are customized for Instantbird actually (the Amazon one, at least, adds the vendor key or whatever to it).
Now with extra bustage:
Timestamp: 05/09/2015 22:20:34
Error: TypeError: this._defaultEngine is null
Source File: resource://gre/components/nsSearchService.js
Line: 4776
Summary: Update search plugins shipped with Instantbird → Update search shipped with Instantbird
The conversation context menu is broken too.
Attached patch PatchSplinter Review
This ports the Makefile.in/jar.mn changes needed to package the search plugins in the omni.ja file instead of in a searchplugins folder in the application directory.

I also added ddg, and updated the other plugins to have HiDPI icons, https URLs, and rel="searchform" instead of a separate <SearchForm>. I haven't touched/updated the CreativeCommons and Answers.com plugins which no longer exist in Firefox.
Attachment #8728159 - Flags: review?(aleth)
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment on attachment 8728159 [details] [diff] [review]
Patch

Review of attachment 8728159 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!

I assume you decided the sync init warning was not worth caring about?
Error: DEPRECATION WARNING: Search service falling back to synchronous initialization. This is generally the consequence of an add-on using a deprecated search service API.
Attachment #8728159 - Flags: review?(aleth) → review+
Keywords: checkin-needed
(In reply to aleth [:aleth] from comment #6)

Thanks for the review!

> I assume you decided the sync init warning was not worth caring about?
> Error: DEPRECATION WARNING: Search service falling back to synchronous
> initialization. This is generally the consequence of an add-on using a
> deprecated search service API.

It's a separate bug (bug 955426) that isn't a blocker.
https://hg.mozilla.org/comm-central/rev/b64643fa52db4b8342fbb57a091b37ae163d2595
Bug 1103432 - Ship updated search plugins in the omni.ja file, r=aleth.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 48
You need to log in before you can comment on or make changes to this bug.