Closed Bug 1039003 Opened 11 years ago Closed 10 years ago

Port |Bug 633773 - Use Google's HTTPS search by default|, |Bug 958883 - Use HTTPS for Yahoo searches| and search plugin parts of |Bug 959576 - Create a component to get the list of priority domains| to Thunderbird

Categories

(Thunderbird :: Search, defect)

Product:
Thunderbird
Component:
Search
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird36 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 36.0
Tracking Flags:
Tracking Status
thunderbird36 --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Keywords: productization)

Attachments

(2 files, 2 obsolete files)

Updated TB searchplugins changes [Checked in: Comment 4]
16.30 KB, patch
mkmelin
: review+
iannbugzilla
: feedback+
Details | Diff | Splinter Review
Fixed missing / and > [Checkin: Comment 7]
5.05 KB, patch
mkmelin
: review+
Details | Diff | Splinter Review
Attached patch TB searchplugins changes (obsolete) — — Splinter Review
Yahoo and Google search over HTTPS now work in a useful way, so we should do the same switch as Firefox. We also need to match the search plugin changes from Bug 959576.
Attachment #8456507 - Flags: feedback?(mconnor)
Depends on: 633773, 958883, 959576
Assignee: nobody → iann_bugzilla
Attached patch Revised TB searchplugins changes (obsolete) — — Splinter Review
Patch now: * Ports Bug 557665, and updates the <SearchForm> lines for each search plugin * Ports Bug 557890, and updates the Google search plugin suggestion URLs * Applies changes from Bug 331143 to the AOL search plugin * Takes the changes suggested in Bug 1039004, has a distinct appID for the yahoo search plugin and the suggestions URL in the Google search plugin now uses Params
Attachment #8456507 - Attachment is obsolete: true
Attachment #8456507 - Flags: feedback?(mconnor)
Attachment #8459317 - Flags: review?(mkmelin+mozilla)
Attachment #8459317 - Flags: feedback?(mconnor)
Status: NEW → ASSIGNED
Depends on: 331143, 557665, 557890
Comment on attachment 8459317 [details] [diff] [review] Revised TB searchplugins changes If you're going to do line breaks in between attributes, I'd strongly encourage one attribute per line i.e. +<Url type="text/html" method="GET" + template="https://search.yahoo.com/" rel="searchform"/> is easier to parse for me as +<Url type="text/html" + method="GET" + template="https://search.yahoo.com/" + rel="searchform"/> Mostly because the short lines make me assume it's attr-per-line and I had to reread.
Attachment #8459317 - Flags: feedback?(mconnor) → feedback+
Revised as per feedback, carrying forward f+
Attachment #8459317 - Attachment is obsolete: true
Attachment #8459317 - Flags: review?(mkmelin+mozilla)
Attachment #8459753 - Flags: review?(mkmelin+mozilla)
Attachment #8459753 - Flags: feedback+
Attachment #8459753 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 8459753 [details] [diff] [review] Updated TB searchplugins changes [Checked in: Comment 4] https://hg.mozilla.org/comm-central/rev/7d2996eda4fe
Attachment #8459753 - Attachment description: Updated TB searchplugins changes → Updated TB searchplugins changes [Checked in: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
Depends on: 1097484
Blocks: 1100672
Reopening because this needs to be fixed before it reaches aurora. Note that all locales shipping Google at this point have a broken in-product search.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Asking for retrospective r= https://hg.mozilla.org/comm-central/rev/aec4a3e24327
Flags: needinfo?(iann_bugzilla)
Attachment #8527202 - Flags: review?(mkmelin+mozilla)
Attachment #8527202 - Flags: review?(mkmelin+mozilla) → review+
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: