1039003 - Port |Bug 633773 - Use Google's HTTPS search by default|, |Bug 958883 - Use HTTPS for Yahoo searches| and search plugin parts of |Bug 959576 - Create a component to get the list of priority domains| to Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Ian Neal]

Attachment: TB searchplugins changes

Yahoo and Google search over HTTPS now work in a useful way, so we should do the same switch as Firefox. We also need to match the search plugin changes from Bug 959576.

Comment 1

[Ian Neal]

Attachment: Revised TB searchplugins changes

Patch now:
* Ports Bug 557665, and updates the <SearchForm> lines for each search plugin
* Ports Bug 557890, and updates the Google search plugin suggestion URLs
* Applies changes from Bug 331143 to the AOL search plugin
* Takes the changes suggested in Bug 1039004, has a distinct appID for the yahoo search plugin and the suggestions URL in the Google search plugin now uses Params

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 8459317 [details] [diff] [review]
Revised TB searchplugins changes

If you're going to do line breaks in between attributes, I'd strongly encourage one attribute per line

i.e. 
+<Url type="text/html" method="GET"
+     template="https://search.yahoo.com/" rel="searchform"/>

is easier to parse for me as

+<Url type="text/html"
+     method="GET"
+     template="https://search.yahoo.com/"
+     rel="searchform"/>

Mostly because the short lines make me assume it's attr-per-line and I had to reread.

Comment 3

[Ian Neal]

Attachment: Updated TB searchplugins changes [Checked in: Comment 4]

Revised as per feedback, carrying forward f+

Comment 4

[Ian Neal]

Comment on attachment 8459753 [details] [diff] [review]
Updated TB searchplugins changes [Checked in: Comment 4]

https://hg.mozilla.org/comm-central/rev/7d2996eda4fe

Comment 5

[Francesco Lodolo [:flod]]

Has anyone noticed anything wrong with this yet? There are at least two malformed XML files (aol, google).

http://hg.mozilla.org/comm-central/raw-file/f3ff335c5f9f/mail/locales/en-US/searchplugins/aol-web-search.xml
http://hg.mozilla.org/comm-central/raw-file/f3ff335c5f9f/mail/locales/en-US/searchplugins/google.xml

Comment 6

[Francesco Lodolo [:flod]]

Reopening because this needs to be fixed before it reaches aurora. Note that all locales shipping Google at this point have a broken in-product search.

Comment 7

[Ian Neal]

Attachment: Fixed missing / and > [Checkin: Comment 7]

Asking for retrospective r=
https://hg.mozilla.org/comm-central/rev/aec4a3e24327