Closed Bug 1103439 Opened 5 years ago Closed 5 years ago

ImageLib's chrome tests need to clear the chrome image cache, not the regular image cache

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(1 file, 1 obsolete file)

ImageLib has a number of chrome tests that need to clear the cache to work properly. Unfortunately, the function they're using to do it, |clearImageCache|, does not clear the correct cache - the images used by chrome tests are chrome images, but |clearImageCache| clears only the regular image cache.

We need to add another function that clears both caches, and call it in all ImageLib mochitest-chrome tests.

I believe this may be the real cause of bug 1100497, so I'm going to try reenabling it after this lands.
(In reply to Seth Fowler [:seth] from comment #0)
> I believe this may be the real cause of bug 1100497, so I'm going to try
> reenabling it after this lands.

Reenabling 'test_animation.html', to be clear.
Here's the patch.
Attachment #8527247 - Flags: review?(tnikkel)
Comment-only tweak.
Attachment #8527249 - Flags: review?(tnikkel)
Attachment #8527247 - Attachment is obsolete: true
Attachment #8527247 - Flags: review?(tnikkel)
Attachment #8527249 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/mozilla-central/rev/faa77ca026ea
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.