Closed Bug 1103648 Opened 9 years ago Closed 9 years ago

PlatformDecoderModule::Shutdown() is no longer being called

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1038031's patch to make the MP4Reader async removed the call to PDM::Shutdown(). It also made the PDM destroyed on the main thread, we can put this back on the decode thread like it was before bug 1038031 landed, as the reason why it had to be OMT was removed in bug 1047824, which was fixed after I initially wrote the patch for bug 1038031...

This manifests as an assertion in the EME PDM's dtor when it deletes its task queue, as it complains that the task queue has not been shutdown (because PDM::Shutdown() wasn't called). This only happens when using the EME non-wrapping the platform's PDM, i.e. not the path we (currently) take on our test infrastructure.

I'll upload a patch...
s/1038031/1032633/g
Blocks: 1032633
No longer blocks: 1038031
Attachment #8527361 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/853cd19f85bd
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Mass update firefox-status to track EME uplift.
You need to log in before you can comment on or make changes to this bug.