1103896 - [Settings][Dialog] Warning of data connection and data romaing should be shown as a dialog

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

+++ This bug was initially created as a clone of Bug #1103894 +++

The warning should be shown as a dialog. We should use settings dialog to show it.

STR:
1. Flash the phone
2. Launch settings app
3. Open the Cellular & Data panel
4. Turn on data connection or data roaming 

Actual:
  The warning slides in from the right hand side.

Expected:
  The warning is displayed like a dialog

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/26934

EJ, could you help review the patch? Thanks.

In addition to migrate to the dialog service, I also moved the function a little bit and made them more self-contained which may help refactoring in the future.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8539957 [details]
link to https://github.com/mozilla-b2g/gaia/pull/26934

r+ with few nits addressed. Thanks Arthur !!

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks EJ!

master: 7fa66f7c4909935aa7167388e1d3a0b6c1d6cd5b