Closed
Bug 1103915
Opened 10 years ago
Closed 10 years ago
Task Tracer: timestamp skew in different processes
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: cyu, Assigned: cyu)
References
Details
Attachments
(1 file, 1 obsolete file)
8.20 KB,
patch
|
sinker
:
review+
|
Details | Diff | Splinter Review |
Bug 1064673 uses TimeDuration from profiler start time in Task Tracer. Duration from start in tasktracer makes timestamp data easier to interpret, but different processes have different start time. This leads to strange behavior, such as backward time travel, in Task Tracer.
We need to find another way to use duration from start that is consistent among processes.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8527635 -
Attachment is obsolete: true
Attachment #8539092 -
Flags: review?(tlee)
Comment 3•10 years ago
|
||
Is there a corresponding convertor bug?
Assignee | ||
Comment 4•10 years ago
|
||
We can add the converter change as part 2.
Comment 5•10 years ago
|
||
Comment on attachment 8539092 [details] [diff] [review]
Output absolute times and profiler starting time (v2)
Review of attachment 8539092 [details] [diff] [review]:
-----------------------------------------------------------------
please fix GetLoggedData() before landing.
::: tools/profiler/GeckoTaskTracer.h
@@ +67,2 @@
> void StopLogging();
> nsTArray<nsCString>* GetLoggedData(TimeStamp aStartTime);
We don't need |aStartTime| anymore.
Attachment #8539092 -
Flags: review?(tlee) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
For the record, the corresponding change to the converter is in https://github.com/ginayeh/B2G/commit/f18136cf01b4d05e02eecf3a37cf35442fb8ebc6 and will land with bug 956620.
Comment 9•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•