Closed
Bug 1103970
Opened 10 years ago
Closed 10 years ago
Remove affiliate codes from default Google plugin in ja / ja-JP-mac
Categories
(Mozilla Localizations :: ja / Japanese, defect, P1)
Mozilla Localizations
ja / Japanese
Tracking
(firefox34+ fixed, firefox35+ fixed, firefox36+ fixed)
People
(Reporter: Pike, Assigned: Gavin)
References
Details
Attachments
(1 file, 3 obsolete files)
4.38 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1103216 +++
Per expiration of the search agreement, the Google affiliate codes must be removed from any and all official builds.
Cloning the en-US bug to get one on file for Japanese.
Bug 1103216 comment 4 says that google would prefer us to not have a separate plugin.
The best/most recent history I found for the different plugins is in bug 534125,
"According to Google, redirect from www.google.com to www.google.co.jp isn't
always correct. For example if gateway server isn't in their country, they are
redirected to other language server depending on the gateway server location.
So, we should keep using google-jp.xml with www.google.co.jp urls."
That was in 2009.
I'm not sure if we should make that decision in the next few hours or just fix the params instead. I'm leaning towards the latter.
We can land stuff on hg.m.o and get that in, I'm not sure how to back port those to https://code.google.com/p/mozja/source/browse/#hg%2Fja, which the team uses to create ja and ja-JP-mac.
Comment 1•10 years ago
|
||
Agreed we should focus on removing codes vs. removing plugins for 34. Attached please find a patch for https://code.google.com/p/mozja/source/browse/#hg%2Fja which removes codes. I have left the client code in for the seamonkey suite, but the rls and aq codes shoukd come out. For the Firefox-specific plugins, client codes, rls codes, search access point identifiers, and aq code (which was originally used to identify search bar queries) have been removed.
Note that these changes need to be pushed and our repos updated. If we want a regular patch for our repos please let me know.
Note also that this is a requirement for 34; it must land.
Attachment #8527696 -
Flags: feedback?(mconnor)
Comment 2•10 years ago
|
||
Patch for ja in l10n-central
Comment 3•10 years ago
|
||
patch for ja-JP-mac in l10n-central
Comment 4•10 years ago
|
||
Comment on attachment 8527696 [details] [diff] [review]
Remove affliate codes from Google JA plugins in https://code.google.com/p/mozja/
This will also need to remove the instances of #expand __GOOGLE_CLIENT_PARAM__
This is ok on "minimum overhead" principle, but we should really just kill all of the preprocessing and remove the application/x-moz-keywordsearch and application/x-moz-contextsearch URLs.
Updated•10 years ago
|
Attachment #8527696 -
Flags: feedback?(mconnor) → feedback+
Assignee | ||
Comment 5•10 years ago
|
||
Assignee: nobody → gavin.sharp
Attachment #8527696 -
Attachment is obsolete: true
Attachment #8527712 -
Attachment is obsolete: true
Attachment #8527714 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8527834 -
Flags: review?(mconnor)
Assignee | ||
Comment 6•10 years ago
|
||
(same patch applies to ja-JP-mac)
Comment 7•10 years ago
|
||
Comment on attachment 8527834 [details] [diff] [review]
ja patch against beta
This'll do, though I suspect Google would want us to drop the hl param in a future update. We can do that when we kill the different plugin in the future.
Attachment #8527834 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 8•10 years ago
|
||
http://hg.mozilla.org/releases/l10n/mozilla-beta/ja/rev/532620d720cd
http://hg.mozilla.org/releases/l10n/mozilla-release/ja/rev/532620d720cd
http://hg.mozilla.org/releases/l10n/mozilla-beta/ja-JP-mac/rev/f1cef198c5c1
http://hg.mozilla.org/releases/l10n/mozilla-release/ja-JP-mac/rev/f1cef198c5c1
status-firefox34:
--- → fixed
status-firefox35:
--- → affected
status-firefox36:
--- → affected
tracking-firefox34:
--- → +
tracking-firefox35:
--- → +
tracking-firefox36:
--- → +
Reporter | ||
Comment 9•10 years ago
|
||
marsf, we'll need this change to land on both aurora and central still.
Can you help with that?
I'll have to reject the sign-offs for 35 until we have that resolved, sorry.
Flags: needinfo?(chimantaea_mirabilis)
Comment 10•10 years ago
|
||
aurora (ja/ja-JP-mac):
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/32383279998b
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/578f6095f936
central (ja/ja-JP-mac):
http://hg.mozilla.org/l10n-central/ja/rev/608df4a0c172
http://hg.mozilla.org/l10n-central/ja-JP-mac/rev/aba6f4f0ee5e
(In reply to Axel Hecht [:Pike] from comment #0)
> We can land stuff on hg.m.o and get that in, I'm not sure how to back port
> those to https://code.google.com/p/mozja/source/browse/#hg%2Fja, which the
> team uses to create ja and ja-JP-mac.
We are applying changes between hg.m.o and code.google.com/mozja manually.
I'll back port the change later.
Flags: needinfo?(chimantaea_mirabilis)
Reporter | ||
Comment 11•10 years ago
|
||
Great, thanks.
Sign-offs accepted, too.
Assignee | ||
Comment 12•10 years ago
|
||
Sounds like this is FIXED, then - can you just confirm Axel?
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(l10n)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•