Some codecs output a first frame with length = 0 right after seeking, in current OmxDecoder seek design , it will make seek not end in a while loop. http://dxr.mozilla.org/mozilla-central/source/dom/media/omx/OmxDecoder.cpp?from=OmxDecoder.cpp#596
blocking-b2g: 2.0M? → 2.0M+
status-b2g-v2.0M: --- → affected
Created attachment 8528283 [details] [diff] [review] Bug-1104411-Continue-reading-frame-if-the-length-is-.patch Continue reading frame if the length of frame is 0 when seeking.
Hi Wayne, Could you please help test the patch (attachment 8528283 [details] [diff] [review]) to see if it can work or not? Thanks a lot!
I have tested it on my Flame. It can work well.
bwu, isn't this bug affect to b2gv2.0?
The problem mentioned in comment 0 currently only happen on the platform in Bug 1054172 and cannot be seen in Flame 2.0. In the attached patch, I am trying to have a solution for all platforms with different codec behavior. Not sure if other platforms in the future will also hit this problem. We may need to check in to 2.0 as well besides 2.0m if there is no other concerns.
Hi Blake, It works in woodduck.
Thanks a lot! Wayne
Created attachment 8528760 [details] [diff] [review] Bug-1104411-Continue-to-read-next-frame-if-the-lengt.patch Add some comments to attachment 8528283 [details] [diff] [review].
Comment on attachment 8528760 [details] [diff] [review] Bug-1104411-Continue-to-read-next-frame-if-the-lengt.patch Looks good!
Attachment #8528760 - Flags: review?(sotaro.ikeda.g) → review+
Test results looks good compared to . https://tbpl.mozilla.org/?tree=Try&rev=19cd786092b5 https://tbpl.mozilla.org/?tree=Mozilla-B2g32-v2.0
Created attachment 8529731 [details] [diff] [review] Master-Bug-1104411-Continue-to-read-next-frame-if-the-lengt.patch 1. Carry r+ from sotaro. 2. Rebase attachment 8528760 [details] [diff] [review] to Master branch.
Attachment #8529731 - Flags: review+
Created attachment 8529739 [details] [diff] [review] (2.0m)Bug-1104411-Continue-to-read-next-frame-if-the-lengt.patch 1. Carry r+ from sotaro. 2. Clear the commit message.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2b4aa8341ca9 Testing result looks good! Please check in attachment 8529731 [details] [diff] [review] to master branch.
Hi seinlin, Please help check in attachment 8529739 [details] [diff] [review] to 2.0M branch if no concerns. Thanks!
b2g-inbound https://hg.mozilla.org/integration/b2g-inbound/rev/0b338c05b865 v2.0m http://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/615c3b5245a3
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
status-b2g-v2.0M: affected → fixed
status-b2g-v2.2: unaffected → fixed
You need to log in before you can comment on or make changes to this bug.