Closed Bug 1104476 Opened 11 years ago Closed 11 years ago

Enable MOZ_NFC on L

Categories

(Firefox OS Graveyard :: NFC, defect)

Product:
Firefox OS Graveyard
Component:
NFC
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.2+, firefox36 wontfix, firefox37 wontfix, firefox38 fixed, b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S5 (6feb)
Project Flags:
feature-b2g 2.2+
Tracking Flags:
Tracking Status
firefox36 --- wontfix
firefox37 --- wontfix
firefox38 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: dimi, Assigned: allstars.chh)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

Patch.
1.06 KB, patch
glandium
: review+
bajaj
: approval-mozilla-b2g37+
Details | Diff | Splinter Review
We need to make sure that NFC function can work on Nexus5 lolipop version
Two part need to be update to enable NFC in Nexus5 lolipop - Add MOZ_NFC in configure.in - Add ro.moz.nfc.enabled=true
Summary: Verify NFC functionality on Nexus5 - L → Enable NFC on Nexus5 - L
this is fixed by :seinlin
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Hi dimi Can you show the bug numer ? This bug should be duplicated.
Blocks: b2g-nfc
Flags: needinfo?(dlee)
from this revision MOZ_NFC is not defined. https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/file/63b63054948d/configure.in
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hi Seinlin Can you show me the bug where you fixed this? Thanks
Flags: needinfo?(dlee) → needinfo?(kli)
I found it. Bug 1100817
Flags: needinfo?(kli)
Assignee: dlee → allstars.chh
Depends on: 1100817
Summary: Enable NFC on Nexus5 - L → Enable MOZ_NFC on Nexus5 - L
Summary: Enable MOZ_NFC on Nexus5 - L → Enable MOZ_NFC on L
Attached patch Patch. — — Splinter Review
Attachment #8556861 - Flags: review?(shuang)
Comment on attachment 8556861 [details] [diff] [review] Patch. Shawn said he cannot review this, forward to glandium
Attachment #8556861 - Flags: review?(shuang) → review?(mh+mozilla)
Attachment #8556861 - Flags: review?(mh+mozilla) → review+
I need to check out if I caused the failure in Mulet Linux x64 opt M1 before I push this commit, see https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a108fecb303
(In reply to Yoshi Huang[:allstars.chh] from comment #9) > I need to check out if I caused the failure in Mulet Linux x64 opt M1 before > I push this commit, see > https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a108fecb303 The error message is for "Navigator.getMobileIdAssertion", that shouldn't triggered by me
https://hg.mozilla.org/mozilla-central/rev/e0a2fe7ccbed
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Hi Wesley and Vincent Should we uplift this patch to v2.2?
Flags: needinfo?(whuang)
Flags: needinfo?(vchang)
blocking-b2g: --- → 2.2?
L porting is essential to 2.2. Please uplift to 2.2.
blocking-b2g: 2.2? → ---
feature-b2g: --- → 2.2+
Flags: needinfo?(whuang)
Comment on attachment 8556861 [details] [diff] [review] Patch. NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): Bug 1100817 User impact if declined: No NFC on L Testing completed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e63f6f91dd1f Risk to taking this patch (and alternatives if risky): No. String or UUID changes made by this patch: No
Attachment #8556861 - Flags: approval-mozilla-b2g37?
Flags: needinfo?(vchang)
Attachment #8556861 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: