1104739 - [flame][camera][viewfinder] Video preview appears to be aspect fit

Status: RESOLVED DUPLICATE of bug 1104913

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Wilson Page [:wilsonpage]]

Attachment: video-preview-aspect-fit.png

The video viewfinder appears to be aspect fit, when it should be aspect fill. Nothing has changed in the viewfinder positioning logic, so assuming something has changed on the gecko side.

preview-size: { height: 480, width: 864 }
scaled-video-element: { width: 576px, height: 320px }

I believe the client-side scaling logic is correct. It appears Gecko is providing us with a 4:3 aspect preview size, despite us requesting a wider 9:5 aspect preview-size.

I should also mention that this doesn't reproduce on all flames; I remember :mikeh saying there were subtle differences between some Flames.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

The algorithm to determine acceptable preview sizes for a given recording profile were updated in bug 1098660 and bug 1054803 because of distortion in the preview found in bug 1098028.

These were intended to follow the recommendations from the AOSP code:
http://androidxref.com/4.4.4_r1/xref/frameworks/base/core/java/android/hardware/Camera.java#2386

However Gecko should be honouring the aspect ratio if possible, assuming there are options with a 9:5 aspect ratio. I will take a look.

Comment 2

[Wilson Page [:wilsonpage]]

This bug sparked a big debate on IRC about setting up sensible defaults for camera configuration. The proposal is:

"If unspecified, the call to .getCamera() should return a camera that is configured to the best picture/video size, and with a preview-size of the same aspect ratio, as close to the display's device-pixel count as possible."

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

Opened bug 1104913 to add sensible defaults.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

I believe this issue was resolved as part of bug 1104913. The camera now favours matching the aspect ratio of the capture size in both photo and video modes.