1105124 - [FFOS2.0][Woodduck][USSD]MS display the last reply content when ussd reply message come again

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[sync-1]

DEFECT DESCRIPTION:
 >MS display the last reply content when ussd reply message come again
 
  REPRODUCING PROCEDURES:
 Test in the lab
 1.receive a ussd reply message and input some content to reply it(like:*123#)
 2.receive a ussd reply message ang view the reply interface-->KO
 
  EXPECTED BEHAVIOUR:
 The last reply content should not display on the reply interface.
 
 >0752-2639346
 
  ASSOCIATE SPECIFICATION:
  TEST PLAN REFERENCE:
  TOOLS AND PLATFORMS USED:
  USER IMPACT:
  REPRODUCING RATE:
  For FT PR, Please list reference mobile's behavior:

Comment 1

[Julien Wajsberg [:julienw]]

I think USSD is handled in Dialer. Doug, can you confirm?

Comment 2

[sync-1]

https://bugzilla.mozilla.org/show_bug.cgi?id=1090853#c61

Comment 3

[Doug Sherk (:drs) (inactive)]

(In reply to Julien Wajsberg [:julienw] from comment #1)
> I think USSD is handled in Dialer. Doug, can you confirm?

Yes.

(In reply to sync-1 from comment #2)
> https://bugzilla.mozilla.org/show_bug.cgi?id=1090853#c61

I don't have access to bug 1054172 or bug 1090853, so I can't see any of the history being referred to here.

Comment 4

[sync-1]

> (In reply to sync-1 from comment #2)
 > > https://bugzilla.mozilla.org/show_bug.cgi?id=1090853#c61
 > I don't have access to bug 1054172 or bug 1090853, so I can't see any of the
 > history being referred to here.
 
 1.receive a ussd reply message and input some content to reply it(like:*123#).
 
 If we haven't exit dialer app(long press the home key and clear it), MS display the last reply content when ussd reply message come again.

Comment 5

[Josh Cheng [:josh]]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #3)
> (In reply to Julien Wajsberg [:julienw] from comment #1)
> > I think USSD is handled in Dialer. Doug, can you confirm?
> 
> Yes.
> 
> (In reply to sync-1 from comment #2)
> > https://bugzilla.mozilla.org/show_bug.cgi?id=1090853#c61
> 
> I don't have access to bug 1054172 or bug 1090853, so I can't see any of the
> history being referred to here.

Hi Doug,
bug 1054172 is just meta bug for Woodduck project. You can check bug 1090853 for some history. Thanks!

Comment 6

[Josh Cheng [:josh]]

Hi Chens,
Since you fixed bug 1090853, can you also take a look at this one? Thanks!

Comment 7

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request to 2.0m

Hi Doug, 

I've made changes in closeWindow() to reset response messages, could you review it and give some feedback? thanks!

Comment 8

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8530137 [details] [review]
Pull request to 2.0m

This looks good, but this issue exists on master as well. Please create a master PR as well and request review from both Gabriele [:gsvelto] and I.

Note that the fix for master will be slightly different because bug 1031175 landed recently, which makes heavy changes to the MMI/USSD code.

Comment 9

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Comment 4 seems to answer the qawanted request from comment 3.  Please re-tag if there is something else desired.

Comment 10

[Josh Cheng [:josh]]

Hi Kai-Zhen,
Could you help to land this patch on 2.0M? Thanks!

Comment 11

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/3aa0797c111a40e36f722722309668de3d469181

Comment 12

[sync-1]

(In reply to comment #12)
 > Comment from Mozilla:v2.0m:
 > https://github.com/mozilla-b2g/gaia/commit/3aa0797c111a40e36f722722309668de3d469181
 
 ****************************************************
    closeWindow: function mui_closeWindow() {
      window.postMessage({
        type: 'mmi-cancel'
      }, this.COMMS_APP_ORIGIN);
 +    this.resetResponse();
      this.mmiScreen.hidden = true;
    },
 ****************************************************
 I have use this patch do a test and it doesn't work.
 Because we can't close the window after we reply the "USSD Reply Message".
 
 
 So I change the code like this to do a test:
 ****************************************************
    closeWindow: function mui_closeWindow() {
      window.postMessage({
        type: 'mmi-cancel'
      }, this.COMMS_APP_ORIGIN);
      this.mmiScreen.hidden = true;
 +    this.resetResponse();
    },
 ****************************************************
 it's also can't work. The last reply content is there.

Comment 13

[Sherman Chen [:chens] (inactive)]

(In reply to sync-1 from comment #12)
> (In reply to comment #12)
>  > Comment from Mozilla:v2.0m:
>  >
> https://github.com/mozilla-b2g/gaia/commit/
> 3aa0797c111a40e36f722722309668de3d469181
>  
>  ****************************************************
>     closeWindow: function mui_closeWindow() {
>       window.postMessage({
>         type: 'mmi-cancel'
>       }, this.COMMS_APP_ORIGIN);
>  +    this.resetResponse();
>       this.mmiScreen.hidden = true;
>     },
>  ****************************************************
>  I have use this patch do a test and it doesn't work.
>  Because we can't close the window after we reply the "USSD Reply Message".

One thing need to confirm, are you able to close the window after reply "USSD reply message" without this patch?

Comment 14

[sync-1]

(In reply to comment #14)
 > Comment from Mozilla:(In reply to sync-1 from comment #12)
 > > (In reply to comment #12)
 > >  > Comment from Mozilla:v2.0m:
 > >  >
 > > https://github.com/mozilla-b2g/gaia/commit/
 > > 3aa0797c111a40e36f722722309668de3d469181
 > >  
 > >  ****************************************************
 > >     closeWindow: function mui_closeWindow() {
 > >       window.postMessage({
 > >         type: 'mmi-cancel'
 > >       }, this.COMMS_APP_ORIGIN);
 > >  +    this.resetResponse();
 > >       this.mmiScreen.hidden = true;
 > >     },
 > >  ****************************************************
 > >  I have use this patch do a test and it doesn't work.
 > >  Because we can't close the window after we reply the "USSD Reply Message".
 > One thing need to confirm, are you able to close the window after reply "USSD
 > reply message" without this patch?
 
 Yes. 
 After reply "USSD replay message", there display "Session expired" and we can click the [X] to close this window.

Comment 15

[Sherman Chen [:chens] (inactive)]

And can you elaborate what happened after you apply this patch? 
You said it can't close the window after reply the message, does this mean it shows "Session expired" but not able to close the window or something else?

Comment 16

[sync-1]

(In reply to comment #16)
 > Comment from Mozilla:And can you elaborate what happened after you apply this
 > patch? 
 > You said it can't close the window after reply the message, does this mean it
 > shows "Session expired" but not able to close the window or something else?
 
 With the patch, it shows "Session expired" after reply the message, and it not able to close when we click [X].

Comment 17

[Sherman Chen [:chens] (inactive)]

Can you verify mmi_ui.js, do you have resetResponse() in your codebase? 

[1]: https://github.com/mozilla-b2g/gaia/blob/3aa0797c111a40e36f722722309668de3d469181/apps/communications/dialer/js/mmi_ui.js#L135-L138

Comment 18

[sync-1]

(In reply to comment #18)
 > Comment from Mozilla:Can you verify mmi_ui.js, do you have resetResponse() in
 > your codebase? 
 > [1]:
 > https://github.com/mozilla-b2g/gaia/blob/3aa0797c111a40e36f722722309668de3d469181/apps/communications/dialer/js/mmi_ui.js#L135-L138
 
 We have resetResponse() in our codebase and the code is below:
 
 **************************************************************
   resetResponse: function mui_resetResponse() {
     //BEGIN-added by renbo jrd_cd on 20140926 for
     // fix the response-text-reset button can not click
     if (evt)
       evt.preventDefault();
     //END-added by renbo jrd_cd on 20140926 for
     // fix the response-text-reset button can not click
     this.responseTextNode.value = '';
     this.sendNode.setAttribute('disabled', 'disabled');
   },
 **************************************************************
 
 Is there any problem in this code?

Comment 19

[Sherman Chen [:chens] (inactive)]

I don't get it why there's additional code there, but can you remove all of those additional code from your codebase and test again? 

Apparently we have different results because of those additional code, and we are not able to identify the root cause because of that, especially in this kind of remote cooperation situation.

Comment 20

[sync-1]

(In reply to comment #20)
 > Comment from Mozilla:I don't get it why there's additional code there, but can
 > you remove all of those additional code from your codebase and test again? 
 > Apparently we have different results because of those additional code, and we
 > are not able to identify the root cause because of that, especially in this
 > kind of remote cooperation situation.
 
 OK, I will remove all of those additional code and do a test again.

Comment 21

[sync-1]

(In reply to comment #20)
 > Comment from Mozilla:I don't get it why there's additional code there, but can
 > you remove all of those additional code from your codebase and test again? 
 > Apparently we have different results because of those additional code, and we
 > are not able to identify the root cause because of that, especially in this
 > kind of remote cooperation situation.
 
 It's work. Thanks!

Comment 22

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request to master

Hi Doug, Gabriele,

I've create another PR to master, pretty much the same approach as 2.0m but change the test accordingly, could you review it and give some feedback? thanks!

Comment 23

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8534238 [details] [review]
Pull request to master

Looks good to me, try is green so land at will.

Comment 24

[Sherman Chen [:chens] (inactive)]

master: https://github.com/mozilla-b2g/gaia/commit/5a59bd4dddff0ab5b86c93c9dccd7cbfd25ee07f

Comment 25

[sync-1]

Dear Dengwei,
 
 这个问题已解决，对应的内部PR，测试部已经验证通过并关闭了，请关闭此PR，谢谢！