1105319 - We don't allow other donation values with a decimal in it, example 2.00

Status: RESOLVED FIXED

(Mozilla Foundation Communications :: Website, task)

Description

[Becky Weir [:beckster]]

Attachment: Screen Shot 2014-11-26 at 9.46.38 AM.png

+++ This bug was initially created as a clone of Bug #1089403 +++

Build sequential donation form for EOY2014

Scott ---- I entered "2.00" as my donation amount, and I got an error. When I enter "2", it works. I've attached a shot of the error. Hope it helps.

Comment 1

[Becky Weir [:beckster]]

Okay. I feel like a lot of donors might try to enter a number with a decimal. Hopefully not.

Comment 2

[Scott [:thecount] Downe]

I thought this would be easy, but looks like there is a bug in parsley and confusion between html5 input types and parsley.

https://github.com/guillaumepotier/Parsley.js/issues/508

Maybe an update would fix it? Otherwise, more debugging is needed.

Comment 3

[Mavis Ou [:mavis]]

Incorrect dependency here.  :)

Comment 4

[Mavis Ou [:mavis]]

Parsley auto-binds integer validator to HTML type="number" fields (see http://parsleyjs.org/doc/#psly-validators-list) and we can't override that.

There are 2 options we can go with, each with some pros and cons

1) do NOT use HTML type="number"
pros: we can accept non-integer number
cons: on mobile, the number pad won't pop up automatically when the "Other" field is in focus.  Users have to switch to the number pad manually

2) continue using HTML type="number"
pros: on mobile, number pad pops up automatically. This saves users a step from entering the number.
cons: we can only accept integer in the "Other" field

thoughts?

Comment 5

[Becky Weir [:beckster]]

#2 is probably better, if most people are using it on mobile.

Comment 6

[Andrea Wood [:andreawood]]

There's no way to decide this accurately without data. More than 95% of our donor traffic is desktop, so because of that I'm inclined to say #1, but I'm adding Adam to see if there's an easy way to test this.

Comment 7

[Scott [:thecount] Downe]

Yeah, desktop should be the focus.

Donations of 3.50 that get rejected are more likely to either bail, or become 3.00, costing us money.

Where a mobile donation key pad can be toggled between text and numbers.

Let's go with 1.

Comment 8

[Mavis Ou [:mavis]]

Decision: let's go for option #1

Comment 9

[Mavis Ou [:mavis]]

Attachment: GitHub PR

Comment 10

[Scott [:thecount] Downe]

Merged: https://github.com/mozilla/bsd-forms-and-wrappers/pull/66