Closed Bug 1105347 Opened 7 years ago Closed 7 years ago

If something goes wrong in a Loop room, then devices aren't released, and the room isn't left

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
normal
Points:
1

Tracking

(firefox35 verified, firefox36 verified)

VERIFIED FIXED
mozilla36
Iteration:
37.1
Tracking Status
firefox35 --- verified
firefox36 --- verified
Blocking Flags:
backlog Fx35+

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Currently, if something goes wrong in a Loop room, we move to the "Something went wrong" view, but we don't actually stop using devices or anything - which could potentially leave us publishing streams.

I have a fix coming for this.
This calls our wonderful _leave function that does all the tidy up for us.
Attachment #8529149 - Flags: review?(nperriault)
Comment on attachment 8529149 [details] [diff] [review]
If something goes wrong in a Loop room, ensure that devices are released and the room is left fully.

Review of attachment 8529149 [details] [diff] [review]:
-----------------------------------------------------------------

Makes tons of sense.
Attachment #8529149 - Flags: review?(nperriault) → review+
https://hg.mozilla.org/integration/fx-team/rev/6b28a301b9e9
Target Milestone: --- → mozilla36
https://hg.mozilla.org/mozilla-central/rev/6b28a301b9e9
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment on attachment 8529149 [details] [diff] [review]
If something goes wrong in a Loop room, ensure that devices are released and the room is left fully.

Approval Request Comment
[Feature/regressing bug #]: Rooms

[User impact if declined]: Camera can remain active on errors until reload or browse. 

[Describe test coverage new/current, TBPL]: includes tests, on central

[Risks and why]: Important error handling for Rooms.  Low risk; almost all the new code is tests.

[String/UUID change made/needed]: none
Attachment #8529149 - Flags: approval-mozilla-aurora?
Flagging for verification given the privacy implications.
Flags: qe-verify+
Flags: in-moztrap-
Comment on attachment 8529149 [details] [diff] [review]
If something goes wrong in a Loop room, ensure that devices are released and the room is left fully.

Approval Request Comment
Move request to beta
Attachment #8529149 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Attachment #8529149 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed using:
FF 35.0b4
Build Id:20141216120925
OS: Win 7 x64

The verification was done using ProcessExplorer tool(http://www.softpedia.com/get/System/System-Info/Process-Explorer.shtml#download). After the "Something went wrong" view is displayed a search is done after the web cams device id using the ProcessExplorer tool to check if the cam is used by any process.
Status: RESOLVED → VERIFIED
Depends on: 1123349
Verified fixed FF 36b1 Win 7
You need to log in before you can comment on or make changes to this bug.