Closed
Bug 1105347
Opened 9 years ago
Closed 9 years ago
If something goes wrong in a Loop room, then devices aren't released, and the room isn't left
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox35 verified, firefox36 verified)
backlog | Fx35+ |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
If something goes wrong in a Loop room, ensure that devices are released and the room is left fully.
4.51 KB,
patch
|
NiKo
:
review+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Currently, if something goes wrong in a Loop room, we move to the "Something went wrong" view, but we don't actually stop using devices or anything - which could potentially leave us publishing streams. I have a fix coming for this.
Assignee | ||
Comment 1•9 years ago
|
||
This calls our wonderful _leave function that does all the tidy up for us.
Attachment #8529149 -
Flags: review?(nperriault)
Comment on attachment 8529149 [details] [diff] [review] If something goes wrong in a Loop room, ensure that devices are released and the room is left fully. Review of attachment 8529149 [details] [diff] [review]: ----------------------------------------------------------------- Makes tons of sense.
Attachment #8529149 -
Flags: review?(nperriault) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6b28a301b9e9
Target Milestone: --- → mozilla36
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6b28a301b9e9
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment 5•9 years ago
|
||
Comment on attachment 8529149 [details] [diff] [review] If something goes wrong in a Loop room, ensure that devices are released and the room is left fully. Approval Request Comment [Feature/regressing bug #]: Rooms [User impact if declined]: Camera can remain active on errors until reload or browse. [Describe test coverage new/current, TBPL]: includes tests, on central [Risks and why]: Important error handling for Rooms. Low risk; almost all the new code is tests. [String/UUID change made/needed]: none
Attachment #8529149 -
Flags: approval-mozilla-aurora?
Flagging for verification given the privacy implications.
Comment 7•9 years ago
|
||
Comment on attachment 8529149 [details] [diff] [review] If something goes wrong in a Loop room, ensure that devices are released and the room is left fully. Approval Request Comment Move request to beta
Attachment #8529149 -
Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Updated•9 years ago
|
Attachment #8529149 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•9 years ago
|
Comment 9•9 years ago
|
||
Verified as fixed using: FF 35.0b4 Build Id:20141216120925 OS: Win 7 x64 The verification was done using ProcessExplorer tool(http://www.softpedia.com/get/System/System-Info/Process-Explorer.shtml#download). After the "Something went wrong" view is displayed a search is done after the web cams device id using the ProcessExplorer tool to check if the cam is used by any process.
Status: RESOLVED → VERIFIED
Comment 10•9 years ago
|
||
Verified fixed FF 36b1 Win 7
You need to log in
before you can comment on or make changes to this bug.
Description
•