1105347 - If something goes wrong in a Loop room, then devices aren't released, and the room isn't left

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

Currently, if something goes wrong in a Loop room, we move to the "Something went wrong" view, but we don't actually stop using devices or anything - which could potentially leave us publishing streams.

I have a fix coming for this.

Comment 1

[Mark Banner (:standard8)]

Attachment: If something goes wrong in a Loop room, ensure that devices are released and the room is left fully.

This calls our wonderful _leave function that does all the tidy up for us.

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8529149 [details] [diff] [review]
If something goes wrong in a Loop room, ensure that devices are released and the room is left fully.

Review of attachment 8529149 [details] [diff] [review]:
-----------------------------------------------------------------

Makes tons of sense.

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/6b28a301b9e9

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6b28a301b9e9

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8529149 [details] [diff] [review]
If something goes wrong in a Loop room, ensure that devices are released and the room is left fully.

Approval Request Comment
[Feature/regressing bug #]: Rooms

[User impact if declined]: Camera can remain active on errors until reload or browse. 

[Describe test coverage new/current, TBPL]: includes tests, on central

[Risks and why]: Important error handling for Rooms.  Low risk; almost all the new code is tests.

[String/UUID change made/needed]: none

Comment 6

[u279076]

Flagging for verification given the privacy implications.

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8529149 [details] [diff] [review]
If something goes wrong in a Loop room, ensure that devices are released and the room is left fully.

Approval Request Comment
Move request to beta

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0880596a5aad

Comment 9

[Catalin Varga [QA][:VarCat]]

Verified as fixed using:
FF 35.0b4
Build Id:20141216120925
OS: Win 7 x64

The verification was done using ProcessExplorer tool(http://www.softpedia.com/get/System/System-Info/Process-Explorer.shtml#download). After the "Something went wrong" view is displayed a search is done after the web cams device id using the ProcessExplorer tool to check if the cam is used by any process.

Comment 10

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 36b1 Win 7