1105430 - Use github.com/mozilla/build-cloud-tools as RoR

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Rail Aliiev [:rail]]

If there are no objections, we'll need:

* Implement git::repo for PuppetAgain, something like http://hg.mozilla.org/build/puppet/file/6e119c99de67/modules/mercurial/manifests/repo.pp, to be used by http://hg.mozilla.org/build/puppet/file/6e119c99de67/modules/aws_manager/manifests/install.pp#l42
* stop syncyng from hg.m.o to github
* enable syncing from github to git.m.o
* obsolete the hg repo
* enable git::repo against git.m.o
* update the docs

Anything missing here?

Comment 1

[Justin Wood (:Callek)]

if we have the hg repo existing, I'd *much* prefer we continue to sync to it, just lock it instead.

We can even do this work and switch puppet to use gitmo/github after the fact if we keep hg.m.o cloud tools being mirrored from git.

Comment 2

[Rail Aliiev [:rail]]

vcs conversion would add extra complexity to the system... I'd rather just sync repos without conversion.

Comment 3

[Rail Aliiev [:rail]]

Attachment: git-repo-puppet.diff

The patch doesn't take care of the existing hg checkout, I can deal with them manually as a one off.

Comment 4

[Rail Aliiev [:rail]]

Attachment: git-repo-puppet-1.diff

oops, forgot to add the new files.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8529222 [details] [diff] [review]
git-repo-puppet-1.diff

Review of attachment 8529222 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming suggested fix

::: modules/config/manifests/base.pp
@@ +293,5 @@
>      $cloudtrail_s3_bucket = ""
>      # s3 prefix name for aws_manager log parsing
>      $cloudtrail_s3_base_prefix = ""
>      # mercurial repository and branch for cloud-tools
> +    $cloud_tools_hg_repo = "https://git.mozilla.org/build/build-cloud-tools"

s/hg/git/g

Comment 6

[Rail Aliiev [:rail]]

Attachment: git-repo-puppet.diff

with cloud_tools_hg_repo fixed, carry over r=dustin

Comment 7

[Rail Aliiev [:rail]]

Attachment: repo-sync-configs.diff

Not sure if this patch is enough.. Probably also need to delete the hg clone on the vcssync box, all recreate the whole directory all together.

Comment 8

[hwine]

Comment on attachment 8529920 [details] [diff] [review]
repo-sync-configs.diff

Review of attachment 8529920 [details] [diff] [review]:
-----------------------------------------------------------------

This actually needs to be done in several steps:
 - ensure git copy up to date
 - disable current mirroring
 - delete hg repo
 - change permissions on git repo to enable commits

Note: git->hg mirroring is only supported by legacy. We don't want more repos using legacy code if at all possible. If it's really important to have hg copies, the suggestion would be to leave things as they are.

Comment 9

[Rail Aliiev [:rail]]

The intent was to have git-to-git mirroring set up. Pete tells me that it's not supported by the modern vcs2vcs system. Do we ever support this? If not, I'm going to just disable the existing conversion and go with the github repo only.

Comment 10

[Rail Aliiev [:rail]]

Attachment: mozharness_stop_syncing_cloud-tools.diff

Stop vcs syncing hg.m.o to github.

Comment 11

[Rail Aliiev [:rail]]

Attachment: cleanup-configs.diff

These configs are not used anywhere.

Comment 12

[Rail Aliiev [:rail]]

Comment on attachment 8529919 [details] [diff] [review]
git-repo-puppet.diff

remote:   https://hg.mozilla.org/build/puppet/rev/99c439936884
remote:   https://hg.mozilla.org/build/puppet/rev/c62d735cc618

Had to add path to git command

Comment 13

[Rail Aliiev [:rail]]

Attachment: git-q.diff

be quiet

Comment 14

[Rail Aliiev [:rail]]

Comment on attachment 8536697 [details] [diff] [review]
git-q.diff

remote:   https://hg.mozilla.org/build/puppet/rev/f27f3635e95d
remote:   https://hg.mozilla.org/build/puppet/rev/d21ba81e2a33

Comment 15

[Rail Aliiev [:rail]]

Comment on attachment 8536668 [details] [diff] [review]
mozharness_stop_syncing_cloud-tools.diff

remote:   https://hg.mozilla.org/build/mozharness/rev/69259feae977
remote:   https://hg.mozilla.org/build/mozharness/rev/fad592f3ab3a

Comment 16

[Armen [:armenzg]]

mozharness change merged to production.

Comment 17

[hwine]

Okay, so here's what will happen regarding the respositories:
 - start mirror https://github.com/mozilla/build-cloud-tools -> https://git.mozilla.org/build/cloud-tools.git

 - disable commit access to https://hg.mozilla.org/build/cloud-tools/

 - remove mirror from https://hg.mozilla.org/build/cloud-tools/ -> https://github.com/mozilla/build-cloud-tools

At that point, all future commits will be made on github.

Comment 18

[Rail Aliiev [:rail]]

(In reply to Hal Wine [:hwine] (use needinfo) from comment #17)
> Okay, so here's what will happen regarding the respositories:
>  - start mirror https://github.com/mozilla/build-cloud-tools ->
> https://git.mozilla.org/build/cloud-tools.git

I'm going to file a separate file for this.

>  - disable commit access to https://hg.mozilla.org/build/cloud-tools/

I deleted the files in https://hg.mozilla.org/build/cloud-tools/rev/86fbbd2df71d. 

>  - remove mirror from https://hg.mozilla.org/build/cloud-tools/ ->
> https://github.com/mozilla/build-cloud-tools

This is done already.

> At that point, all future commits will be made on github.

Already pushing to that repo! :)