1128620 - cloud-tools update on slaveapi failing

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Justin Wood (:Callek)]

This is probably just a simple puppet change, but:

(prod)[[e-mail] prod]$ tail /var/spool/mail/cltbld
X-Cron-Env: <SHELL=/bin/sh>
X-Cron-Env: <HOME=/home/cltbld>
X-Cron-Env: <PATH=/usr/bin:/bin>
X-Cron-Env: <LOGNAME=cltbld>
X-Cron-Env: <USER=cltbld>
Message-Id: <[e-mail]>
Date: Tue, 20 Jan 2015 07:55:01 -0800 (PST)

/bin/sh: git: command not found


was regressed by:

Bug 1105430


I'm not certain if we need to force re-clone cloud tools on slaveapi or not though.

Comment 1

[Jordan Lund (:jlund)]

I made the mistake of manually updating this today and broke all the things because of: https://bugzilla.mozilla.org/show_bug.cgi?id=1020512#c30

for what it's worth wrt git not being in the path:

(dev)[[e-mail] aws]$ which git
/usr/local/bin/git

looks like we need to add '/usr/local' to PATH:
X-Cron-Env: <PATH=/usr/bin:/bin>

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Cron tasks really shouldn't be relying on PATH, but should specify the fully-qualified pathname of the executable.

Comment 3

[Jordan Lund (:jlund)]

Attachment: 150322_bug_1128620_puppet_slaveapi_git_exe-puppet.patch

Comment 4

[Jordan Lund (:jlund)]

resolved with http://hg.mozilla.org/build/puppet/rev/90668fc6e5b5