1105523 - UITour: Provide a way for some Hello targets to have their info panel arrow on the side instead of top

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Matthew N. [:MattN]]

Two ways we could do this:
A) Add an optional property on some targets that defines whether the arrow should be on the side instead.
B) Argument to the showInfo call. This makes the argument list even longer.

I prefer A.

Comment 1

[Matthew N. [:MattN]]

Attachment: MozReview Request: bz://1105523/MattN

Comment 2

[Matthew N. [:MattN]]

/r/1339 - Bug 1105523 - UITour: Provide a way for some Hello targets to have their info panel arrow on the side r=Unfocused

Pull down this commit:

hg pull review -r 64f260e0edea87cf17576d18375b48455ca3b6c5

Comment 3

[Matthew N. [:MattN]]

https://reviewboard.mozilla.org/r/1337/#review701

::: browser/modules/UITour.jsm
(Diff revision 1)
>        if (aAnchor.targetName == "search") {
> -        alignment = "after_start";
>          xOffset = 18;

I moved this to the "search" target definition.

::: browser/modules/UITour.jsm
(Diff revision 1)
> +      infoPanelPosition: "leftcenter topright",

In case you're wondering, this does The Right Thing in RTL despite the "left" and "right".

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://reviewboard.mozilla.org/r/1337/#review747

Ship It!

Comment 5

[Matthew N. [:MattN]]

Thanks!

https://hg.mozilla.org/integration/fx-team/rev/870b15a253e8

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/870b15a253e8

Comment 7

[Justin Dolske [:Dolske]]

Comment on attachment 8533421 [details]
MozReview Request: bz://1105523/MattN

[Triage Comment]

Needed for Fx35 Hello tour, no unusual risk.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c220a894c671

Comment 9

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-beta/rev/428e51cf8e69

Comment 11

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1105523 - UITour: Provide a way for some Hello targets to have their info panel arrow on the side r=Unfocused