UITour: Provide a way for some Hello targets to have their info panel arrow on the side instead of top

RESOLVED FIXED in Firefox 35

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

Trunk
Firefox 37
Points:
3
Bug Flags:
firefox-backlog +
in-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed, firefox37 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Two ways we could do this:
A) Add an optional property on some targets that defines whether the arrow should be on the side instead.
B) Argument to the showInfo call. This makes the argument list even longer.

I prefer A.
Flags: qe-verify-
Flags: firefox-backlog+
Created attachment 8533421 [details]
MozReview Request: bz://1105523/MattN
Attachment #8533421 - Flags: review?(bmcbride)
/r/1339 - Bug 1105523 - UITour: Provide a way for some Hello targets to have their info panel arrow on the side r=Unfocused

Pull down this commit:

hg pull review -r 64f260e0edea87cf17576d18375b48455ca3b6c5
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Iteration: --- → 37.1
status-firefox35: --- → affected
status-firefox36: --- → affected
status-firefox37: --- → affected
https://reviewboard.mozilla.org/r/1337/#review701

::: browser/modules/UITour.jsm
(Diff revision 1)
>        if (aAnchor.targetName == "search") {
> -        alignment = "after_start";
>          xOffset = 18;

I moved this to the "search" target definition.

::: browser/modules/UITour.jsm
(Diff revision 1)
> +      infoPanelPosition: "leftcenter topright",

In case you're wondering, this does The Right Thing in RTL despite the "left" and "right".

Updated

4 years ago
Iteration: 37.1 → 37.2
Attachment #8533421 - Flags: review?(bmcbride) → review+
Thanks!

https://hg.mozilla.org/integration/fx-team/rev/870b15a253e8
status-firefox37: affected → fixed
Flags: in-testsuite+
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/870b15a253e8
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Comment on attachment 8533421 [details]
MozReview Request: bz://1105523/MattN

[Triage Comment]

Needed for Fx35 Hello tour, no unusual risk.
Attachment #8533421 - Flags: approval-mozilla-beta+
Attachment #8533421 - Flags: approval-mozilla-aurora+

Updated

4 years ago
status-firefox36: affected → fixed
Comment on attachment 8533421 [details]
MozReview Request: bz://1105523/MattN
Attachment #8533421 - Attachment is obsolete: true
Attachment #8618741 - Flags: review+
Created attachment 8618741 [details]
MozReview Request: Bug 1105523 - UITour: Provide a way for some Hello targets to have their info panel arrow on the side r=Unfocused
You need to log in before you can comment on or make changes to this bug.