Closed
Bug 1105523
Opened 10 years ago
Closed 9 years ago
UITour: Provide a way for some Hello targets to have their info panel arrow on the side instead of top
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
People
(Reporter: MattN, Assigned: MattN)
References
Details
Attachments
(1 file, 1 obsolete file)
Two ways we could do this: A) Add an optional property on some targets that defines whether the arrow should be on the side instead. B) Argument to the showInfo call. This makes the argument list even longer. I prefer A.
Flags: qe-verify-
Flags: firefox-backlog+
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8533421 -
Flags: review?(bmcbride)
Assignee | ||
Comment 2•9 years ago
|
||
/r/1339 - Bug 1105523 - UITour: Provide a way for some Hello targets to have their info panel arrow on the side r=Unfocused Pull down this commit: hg pull review -r 64f260e0edea87cf17576d18375b48455ca3b6c5
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Iteration: --- → 37.1
status-firefox35:
--- → affected
status-firefox36:
--- → affected
status-firefox37:
--- → affected
Assignee | ||
Comment 3•9 years ago
|
||
https://reviewboard.mozilla.org/r/1337/#review701 ::: browser/modules/UITour.jsm (Diff revision 1) > if (aAnchor.targetName == "search") { > - alignment = "after_start"; > xOffset = 18; I moved this to the "search" target definition. ::: browser/modules/UITour.jsm (Diff revision 1) > + infoPanelPosition: "leftcenter topright", In case you're wondering, this does The Right Thing in RTL despite the "left" and "right".
Updated•9 years ago
|
Iteration: 37.1 → 37.2
Updated•9 years ago
|
Attachment #8533421 -
Flags: review?(bmcbride) → review+
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/1337/#review747 Ship It!
Assignee | ||
Comment 5•9 years ago
|
||
Thanks! https://hg.mozilla.org/integration/fx-team/rev/870b15a253e8
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/870b15a253e8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Comment 7•9 years ago
|
||
Comment on attachment 8533421 [details]
MozReview Request: bz://1105523/MattN
[Triage Comment]
Needed for Fx35 Hello tour, no unusual risk.
Attachment #8533421 -
Flags: approval-mozilla-beta+
Attachment #8533421 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/428e51cf8e69
Assignee | ||
Comment 10•9 years ago
|
||
Attachment #8533421 -
Attachment is obsolete: true
Attachment #8618741 -
Flags: review+
Assignee | ||
Comment 11•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•