Closed Bug 1080942 (fx-UITour-Hello) Opened 5 years ago Closed 5 years ago

UITour modifications for Firefox Hello

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: Dolske, Unassigned)

References

Details

(Keywords: meta)

Attachments

(2 files, 1 obsolete file)

The launch of Firefox Hello will have an associated tour, which will require some additions to our UITour to allow interaction with Hello. This bug tracks that work.
Depends on: 1080943
Depends on: 1080944
Depends on: 1080947
Depends on: 1080948
Depends on: 1080953
Attached image Draft wireframes (obsolete) —
Keywords: meta
A few other parts that will be implemented by other bugs which are probably already filed elsewhere:

* Hello button should glow blue until tour is started or skipped
* Hello panel gear button should have a "Tour" entry to take tour again (verified strings already landing for 35)
* Hello's First Time Experience (FTE) flavor of the panel with a Get Started button that launches the tour.

I think we'll also want some way to skip the tour without launching it. Maybe overload the close button on the TOS/privacy section of the panel to skip the tour as well?
First Time Experience panel via https://people.mozilla.org/~dhenein/loop/rooms/
Updated wireframes
Attachment #8502930 - Attachment is obsolete: true
Blocks: 1044994
Depends on: 1045927
Blocks: 1049017
No longer blocks: 1044994
Is there a demo version that can be tested of this tour?
Flags: needinfo?(dolske)
QA Contact: catalin.varga
I don't think work has started on the webpage yet and I'm just starting on bug 1080944 today.
What Matt said. Implementation hasn't even started yet, far too early to be talking about testing it.
Flags: needinfo?(dolske)
Blocks: 1098620
Depends on: 1101825
Depends on: 1107488
Depends on: 1108644
Hey Matt -- Which of the UI Tour bugs do we want to uplift to Fx35?  Can you and/or Dolske write uplift approvals for the bugs that need to be uplifted --- and then needinfo me on the bugs that should be uplifted?  (I'll then make sure they actually get uplifted.)

I'm doing the needinfo to you from the meta bug because I thought that was cleaner/simpler than doing it on each of the individual bugs.

Thanks!
Flags: needinfo?(MattN+bmo)
No longer depends on: 984140
Depends on: 1112525
Depends on: 1112565
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #8)
> Hey Matt -- Which of the UI Tour bugs do we want to uplift to Fx35?  Can you
> and/or Dolske write uplift approvals for the bugs that need to be uplifted
> --- and then needinfo me on the bugs that should be uplifted?  (I'll then
> make sure they actually get uplifted.)

The bugs have approvals but I will uplift them tomorrow to make sure they're done in the right order without bitrotting each-other unless someone else wants to take the time. It's probably worth doing a try build since there could be dependencies that aren't obvious.
Thanks, Matt -- If you do decide to do the uplifts, can you coordinate with me and Jesup? (To make sure we don't conflict with one another since we have a few patches we're looking to uplift.)  Alternatively, Jesup and I could do all the uplifts (including the UI Tour) as long as you write the approval requests for UI Tour bugs and let us know what we should test. FYI: We test & verify everything we uplift with try builds before we push.
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #10)
> Thanks, Matt -- If you do decide to do the uplifts, can you coordinate with
> me and Jesup? (To make sure we don't conflict with one another since we have
> a few patches we're looking to uplift.)  Alternatively, Jesup and I could do
> all the uplifts (including the UI Tour) as long as you write the approval
> requests for UI Tour bugs and let us know what we should test. FYI: We test
> & verify everything we uplift with try builds before we push.

You're welcome to do it if you want to take the time to do them in order to avoid rebasing. The bugs already have approval AFAIK so I think they can just land after testing on Try.
Flags: needinfo?(MattN+bmo)
Depends on: 1113574
Depends on: 1114486
Should this be resolved fixed? It looks like all of the dependent issues are resolved.
Agreed. The project this was tracking is basically done.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Verified
Status: RESOLVED → VERIFIED
Depends on: 1120909
You need to log in before you can comment on or make changes to this bug.