1105677 - Remove GetURLSearchParams from nsDocShell

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kohei Yoshino]

|location.searchParams| implemented in Bug 1037715 is not available in the latest Aurora (35) nor Nightly (36). The source still has the attribute:

http://dxr.mozilla.org/mozilla-central/source/dom/webidl/URLUtils.webidl

A workaround is |new URLSearchParams(location.search.substr(1))| but I just wanted to it.

Any ideas?

Comment 1

[Peter Van der Beken [:peterv]]

It was disabled in bug 1082734.

Comment 2

[Kohei Yoshino]

I cannot access Bug 1082734 but understood. I'll update the docs and close the bug.

Comment 3

[Andrea Marchesini [:baku]]

Annevk, do we have a solution for this? updating the spec, or proposing a new approach?

Comment 4

[Kohei Yoshino]

https://developer.mozilla.org/en-US/Firefox/Releases/34$revision/703351
https://developer.mozilla.org/en-US/docs/Web/API/Location$revision/703353

Comment 5

[Kohei Yoshino]

Closing for now.

Comment 6

[Anne (:annevk)]

So what I think we should do is remove searchParams completely and make URLSearchParams take (URL or HTMLAreaElement or HTMLAnchorElement or Location or WindowLocation) as argument to extract a url's query more easily.

Comment 7

[Boris Zbarsky [:bzbarsky]]

You mean WorkerLocation, not WindowLocation, right?

I'm probably fine with that....

Comment 8

[Jean-Yves Perrier [:teoli]]

Did it shipped in a released version (34), then has been removed in 35, or has it been removed before 34 released? (Can't get the information from the security bug)

Comment 9

[Kohei Yoshino]

I cannot find this in 34 as well.

Comment 10

[Boris Zbarsky [:bzbarsky]]

> Did it shipped in a released version (34)

No.  location.searchParams has never shipped in a release version.

Comment 11

[Jean-Yves Perrier [:teoli]]

Thanks, so the wiping of this in MDN was the right thing to do :-)

Comment 12

[Jean-Yves Perrier [:teoli]]

Reset the ddn keyword, so that we document what is proposed in comment 6, once defined and implemented.

Comment 13

[Andrea Marchesini [:baku]]

Attachment: usp1.patch

The spec is changed. Currently we don't have URLSearchParams in location so we can get rid of the URLSearchParam obj in the docShell.

Comment 14

[Olli Pettay [:smaug][[e-mail]]]

Anne, is the idea then to have something like .clear() in URLSearchParams?
Though, I guess one can always use url.search = "";

Comment 15

[Olli Pettay [:smaug][[e-mail]]]

Hrm, that comment was for Bug 1174731.

Comment 16

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8625474 [details] [diff] [review]
usp1.patch

Uh, URLSearchParams was odd when it could be used with several things implementing URLUtils.
I wonder why searchParams ever was non-readonly attribute.

Please remove the comment from Location.webidl

Comment 17

[Olli Pettay [:smaug][[e-mail]]]

And change the title of this bug ;)

Comment 18

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e2fe1098aab

Comment 19

[Guilherme Lima]

Landed with the wrong number (missing the second 7) - https://hg.mozilla.org/mozilla-central/rev/1e2fe1098aab

Comment 20

[Eric Shepherd [:sheppy]]

Basically, we need to finish this page: https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams

Comment 21

[Jean-Yves Perrier [:teoli]]

Yes, and this is covered by the dev-doc-needed on bug 887836 (initial implementation, Fx 29) and bug 1174731 (making it read-only, Fx 41).

Calling this specific bug as done.